From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 35019214F5 for ; Wed, 18 Jul 2018 12:52:26 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C5EJAUO9simX for ; Wed, 18 Jul 2018 12:52:26 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E37FD21469 for ; Wed, 18 Jul 2018 12:52:25 -0400 (EDT) From: Kirill Shcherbatov Subject: [tarantool-patches] [PATCH v1 0/3] sql: restrict nullable action definitions Date: Wed, 18 Jul 2018 19:52:19 +0300 Message-Id: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org, Kirill Shcherbatov This patch dissallows define multiple "NULL", "NOT NULL" options per column and fixes silent implicit behavior for invalid "NULL PRIMARY KEY" construction. Then, we remove useless SQL Column structure. Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3473-on-conflict-defaults-fixes Issue: https://github.com/tarantool/tarantool/issues/3473 Kirill Shcherbatov (3): sql: restrict nullable action definitions sql: fixed possible leak in sqlite3EndTable sql: get rid of Column structure src/box/alter.cc | 3 + src/box/field_def.c | 1 + src/box/field_def.h | 2 + src/box/sql/alter.c | 27 ++--- src/box/sql/build.c | 221 +++++++++++++++++++++------------------- src/box/sql/parse.y | 9 +- src/box/sql/resolve.c | 11 +- src/box/sql/select.c | 43 +++----- src/box/sql/sqliteInt.h | 28 ++--- test/sql-tap/conflict3.test.lua | 10 +- test/sql/on-conflict.result | 21 ++++ test/sql/on-conflict.test.lua | 8 ++ 12 files changed, 207 insertions(+), 177 deletions(-) -- 2.7.4