From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 931A9247AD for ; Wed, 16 May 2018 07:32:31 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id keBI6XLnNB-7 for ; Wed, 16 May 2018 07:32:31 -0400 (EDT) Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C46A823FA1 for ; Wed, 16 May 2018 07:32:30 -0400 (EDT) From: Konstantin Belyavskiy Subject: [tarantool-patches] [PATCH 0/3] replication: improve logging. Date: Wed, 16 May 2018 14:32:24 +0300 Message-Id: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: georgy@tarantool.org, kostja@tarantool.org Cc: tarantool-patches@freelists.org Ticket: https://github.com/tarantool/tarantool/issues/3365 Branch: https://github.com/tarantool/tarantool/compare/gh-3365-display-an-error-at-downstream-on-replica-failure-or-disconnect-v3 This is set of patches originally aiming to improve error logging. First patch includes small refactoring (reuse a subset of applier state machine for tracking replication quorum state). Second patch is about do not remove relay on applier disconnect. AR: Konstya, Gosha currently I'm not happy about relay_create part there I use memset for all relay structure, resulting in possible data/state loss. I'm thinking about to use memset only for new relya and reset for others. Third pathc improves logging (duplicate same error for master and replica and store it in relay state). Konstantin Belyavskiy (3): replication: use applier_state to check quorum replication: do not delete relay on applier disconnect replication: display downstream status at upstream src/box/lua/info.c | 19 +++- src/box/relay.cc | 78 ++++++++++---- src/box/relay.h | 30 ++++++ src/box/replication.cc | 60 +++++------ src/box/replication.h | 43 +++----- test/replication/show_error_on_disconnect.result | 120 +++++++++++++++++++++ test/replication/show_error_on_disconnect.test.lua | 38 +++++++ 7 files changed, 305 insertions(+), 83 deletions(-) create mode 100644 test/replication/show_error_on_disconnect.result create mode 100644 test/replication/show_error_on_disconnect.test.lua -- 2.14.3 (Apple Git-98)