From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id AAE662D1F2 for ; Wed, 11 Apr 2018 15:35:09 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5x-oXzE3PcgV for ; Wed, 11 Apr 2018 15:35:09 -0400 (EDT) Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 68F002D1EF for ; Wed, 11 Apr 2018 15:35:09 -0400 (EDT) From: Nikita Pettik Subject: [tarantool-patches] [PATCH 0/2] sql: SQL bindings refactoring Date: Wed, 11 Apr 2018 22:35:03 +0300 Message-Id: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik Branch: https://github.com/tarantool/tarantool/tree/np/gh-3332-format-leak-fix Issue: https://github.com/tarantool/tarantool/issues/3332 First patch introduces fix for leaked tuple formats: under certain circumstances (described in commit message) some tuples from ephemeral space may remain referenced after space's death and as a result, format can't be destroyed. Second patch consists of slight refactoring of cursor closing routine. Nikita Pettik (2): sql: fix tuple format leak sql: refactor cursor closing routine src/box/sql.c | 60 +++++++++++-------------- src/box/sql/cursor.c | 46 ++++++++++--------- src/box/sql/cursor.h | 6 ++- src/box/sql/tarantoolInt.h | 8 ++-- src/box/sql/vdbe.c | 35 +++++---------- src/box/sql/vdbeaux.c | 2 +- test/sql-tap/gh-3332-tuple-format-leak.test.lua | 31 +++++++++++++ 7 files changed, 101 insertions(+), 87 deletions(-) create mode 100755 test/sql-tap/gh-3332-tuple-format-leak.test.lua -- 2.15.1