From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id BD7D52D67F for ; Thu, 5 Apr 2018 15:28:13 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VLxWg_QABOlJ for ; Thu, 5 Apr 2018 15:28:13 -0400 (EDT) Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 137FE2D676 for ; Thu, 5 Apr 2018 15:28:12 -0400 (EDT) From: Vladislav Shpilevoy Subject: [tarantool-patches] [PATCH 0/2] netbox: reuse _request() to do SQL execute() Date: Thu, 5 Apr 2018 22:28:08 +0300 Message-Id: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: kostja@tarantool.org Branch: http://github.com/tarantool/tarantool/tree/gh-3323-3322-sql-iproto-schema-change Issue: https://github.com/tarantool/tarantool/issues/3323 Issue: https://github.com/tarantool/tarantool/issues/3322 _request() is a wrapper for perform_request, that detects schema changes, and waits until it is reloaded. Lets use _request() instead of direct perform_request() for execute(). The reason why the _request() was not used earlier was my attempt to avoid multiple return values in _request(), that leads to minor fixes in non-execute methods like index.select or eval/call_16, which return the _request() directly. But diplicating schema reloading logic for execute() is worse. Vladislav Shpilevoy (2): netbox: forbid conn:timeout():execute(...) netbox: reuse _request() to do SQL execute() src/box/lua/net_box.lua | 77 +++++++++++++++++++++++------------------------ test/box/net.box.result | 5 +-- test/box/net.box.test.lua | 5 +-- test/sql/iproto.result | 45 --------------------------- test/sql/iproto.test.lua | 15 --------- 5 files changed, 44 insertions(+), 103 deletions(-) -- 2.14.3 (Apple Git-98)