From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id EC6CF2BDBE for ; Tue, 3 Apr 2018 12:15:24 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9xx_6hgEmMBO for ; Tue, 3 Apr 2018 12:15:24 -0400 (EDT) Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id ACD142BCEF for ; Tue, 3 Apr 2018 12:15:24 -0400 (EDT) From: Nikita Pettik Subject: [tarantool-patches] [PATCH 0/2] rework SQL 'DROP' routine Date: Tue, 3 Apr 2018 19:14:55 +0300 Message-Id: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik Branch: https://github.com/tarantool/tarantool/tree/np/gh-3222-rework-drop Issue: https://github.com/tarantool/tarantool/issues/3222 This small patch-set implements part of #3222 issue: rewrite functions implementing drop table and drop index in order to avoid using struct Table and its lookup in SQLite data-dictionary. However, as far as currently triggers aren't part of Tarantool's spaces, it is still required to use struct Table to drop them: triggers are held in _trigger space, which format is: ['name', 'sql'], i.e. there is no field for name of parent table. Hence, we are able to point out table's triggers only via accessing struct Table. Both patches are mainly about refactoring. First patch removes useless wrappers, obsolete SQLite specific functions and struct fields. Second one replaces usages of struct Table with struct space in drop routine, fixes codestyle, provides doxygen style comments. Nikita Pettik (2): sql: remove obsolete SQLite routine sql: rework 'DROP INDEX' and 'DROP TABLE' handling src/box/sql/alter.c | 13 +- src/box/sql/analyze.c | 25 ++- src/box/sql/build.c | 442 ++++++++++++++++++------------------------------ src/box/sql/delete.c | 5 +- src/box/sql/expr.c | 9 +- src/box/sql/fkey.c | 3 +- src/box/sql/insert.c | 10 +- src/box/sql/parse.c | 6 +- src/box/sql/parse.y | 6 +- src/box/sql/pragma.c | 18 +- src/box/sql/prepare.c | 29 ---- src/box/sql/select.c | 4 +- src/box/sql/sqliteInt.h | 17 +- src/box/sql/trigger.c | 7 +- src/box/sql/update.c | 2 +- src/box/sql/vdbe.c | 1 - src/box/sql/vdbeInt.h | 1 - src/box/sql/vdbeaux.c | 1 - src/box/sql/where.c | 2 - src/box/sql/wherecode.c | 7 +- 20 files changed, 217 insertions(+), 391 deletions(-) -- 2.15.1