From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4EF01293D2 for ; Thu, 29 Mar 2018 06:18:29 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bpoiPOQmLe6u for ; Thu, 29 Mar 2018 06:18:29 -0400 (EDT) Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0E806207A6 for ; Thu, 29 Mar 2018 06:18:28 -0400 (EDT) From: AKhatskevich Subject: [tarantool-patches] [PATCH 0/3] Ephemeral tables perf leak & next rowid bug Date: Thu, 29 Mar 2018 13:17:49 +0300 Message-Id: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: AKhatskevich Key points: - creater issue #3297 (OP_NextIdEphemeral produces wrong rowids) - #3297 fixed for the most common case (but there still is code in select.c which may fail because of the bug); the fix just allocates register and increments it before each insert - small mem leak fixed AKhatskevich (3): sql: Generate rowid by counter sql: fix memory leak sql: report errors in EphemeralGetMaxId src/box/sql.c | 4 +++- src/box/sql/insert.c | 10 +++++++++- src/box/sql/select.c | 6 +++--- 3 files changed, 15 insertions(+), 5 deletions(-) -- 2.14.1