From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Vladislav Shpilevoy Subject: [PATCH 0/3] console: do not use netbox for console text connections Date: Thu, 22 Mar 2018 22:17:09 +0300 Message-Id: To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Vladislav Shpilevoy List-ID: Branch: http://github.com/tarantool/tarantool/tree/gh-2677-prepare-console-for-push Issue: https://github.com/tarantool/tarantool/issues/2677 At first, netbox text protocol support is full of crutches, slows down a binary protocol support, and complicates a netbox implementation. At second, in #2677 text protocol will have two push types: print pushes, and YAML pushes. It can not be clearly supported in netbox, because it will contain only one callback to process pushed messages. Attempt to fit 3 push types (print, yaml, binary) into netbox will lead to even more complicated netbox. The text protocol must be supported by console only, and directly via sockets. Vladislav Shpilevoy (3): netbox: allow to create a netbox connection from existing socket console: do not use netbox for console text connections netbox: deprecate console support src/box/lua/console.lua | 178 +++++++++++++++++++++++++++++++++++++--------- src/box/lua/net_box.lua | 91 +++++++++++++++++------- test/box/net.box.result | 78 +++++++++++++++++++- test/box/net.box.test.lua | 33 ++++++++- 4 files changed, 318 insertions(+), 62 deletions(-) -- 2.14.3 (Apple Git-98)