From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8A724581FDB; Thu, 17 Aug 2023 10:39:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8A724581FDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1692257970; bh=figxwLiZ8DquIdmhql5e5Kv7eyYuZJTwVhn4+/0U4ps=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=h7kIZ98d6H871I6argai+wkoai0cTsCaZHIG2LaMjRxBkXFqJYEElVOYZIk4R139v tDzu/vYflncc39Nbs0XjkhjaeHGPfJG2WNfnDmsEFwslQ2b7TbR4YmWhb+PVRaEwTZ jIkD37g/NkO3RhHYz+w+MOP9zPEK0Cd252LJp10Y= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E8EF1581FDB for ; Thu, 17 Aug 2023 10:39:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E8EF1581FDB Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qWXbM-0007Cn-8N; Thu, 17 Aug 2023 10:39:28 +0300 Message-ID: Date: Thu, 17 Aug 2023 10:39:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Sergey Kaplun , Igor Munkin Cc: tarantool-patches@dev.tarantool.org References: <08708e70d731d2f0ac7d30399888f5620d06df16.1691592488.git.skaplun@tarantool.org> In-Reply-To: <08708e70d731d2f0ac7d30399888f5620d06df16.1691592488.git.skaplun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9700E0DCE2907754D77D6FA938422CA5F653AC3988EEC6B12182A05F538085040BC8054DC3EB54AF96415403C31D158E1C07FE2FC9FFB4E83688BA545FDD97302 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70CB15FA6C489297DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637145E7A1B378D9E388638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8CA4AA8321E447E2AE47D661198B49508117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCC0EC8C44E4C1BEE2A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C0FE3A47D6FA29121068655334FD4449CB33AC447995A7AD18A91E23F1B6B78B78D5E8D9A59859A8B6F7FD1A3A8AE6177F089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A58DA5F4DCE4F9DEF08A4D9A7F408719122CD962B457D8CDDDF87CCE6106E1FC07E67D4AC08A07B9B09E541A154B51D14BCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF339F39D6928268476FB09D95A9DFB907DE559A76A0843BB643A587A04EB9B983AE7801A017AB3E4A24F7434E9608BF9F1333E248FD8BEEA11B79810E3732034EE48CAC7CA610320002C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojFRrmMqSMPxrhVTkhhud3lw== X-DA7885C5: 27F312822CB2AA906FC02678FBDBAEB39C1AFA682AB484269BB87693E86C97A1262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B23BC84F7C8449678E95DB33203AD594ADD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 12/19] DynASM: Fix warning. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM On 8/9/23 18:36, Sergey Kaplun wrote: > From: Mike Pall > > (cherry-picked from commit 9b41062156779160b88fe5e1eb1ece1ee1fe6a74) > > This patch adds the `/* fallthrough */` comments elsewhere, where it was > missing for the ARM64 build, so the `-Wimplicit-fallthrough` [1] warning > is trigerred. > > [1]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough > > Sergey Kaplun: > * added the description for the commit > > Part of tarantool/tarantool#8825 > --- > dynasm/dasm_arm64.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dynasm/dasm_arm64.h b/dynasm/dasm_arm64.h > index 47e1e074..ff21236d 100644 > --- a/dynasm/dasm_arm64.h > +++ b/dynasm/dasm_arm64.h > @@ -427,6 +427,7 @@ int dasm_encode(Dst_DECL, void *buffer) > break; > case DASM_REL_LG: > CK(n >= 0, UNDEF_LG); > + /* fallthrough */ > case DASM_REL_PC: > CK(n >= 0, UNDEF_PC); > n = *DASM_POS2PTR(D, n) - (int)((char *)cp - base) + 4;