From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id CC5ED29E46 for ; Thu, 16 Aug 2018 17:08:54 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LnPlNGof3ZjZ for ; Thu, 16 Aug 2018 17:08:54 -0400 (EDT) Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8A74729E45 for ; Thu, 16 Aug 2018 17:08:54 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 1/1] box: option to start tarantool with no format checks. References: From: Vladislav Shpilevoy Message-ID: Date: Fri, 17 Aug 2018 00:08:52 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, imeevma@tarantool.org Thanks for the patch! I have pushed my review fix on a separate commit. Please, look at it, squash. Then the patch will be lgtm. On 14/08/2018 14:50, imeevma@tarantool.org wrote: > It is a common case that an instance is running on a version > 1.6.*, then is upgraded to 1.9 with box.schema.upgrade(). But > some of users has malformed space formats, and some of them got > and ignored errors on box.schema.upgrade(). Such half-upgraded > data can not be used to start a new version due to format > violations, and can not be rolled back because some of new system > spaces managed to be created. And we can not repair raw xlogs and > snapshots because we have no such tools and they are zipped. > > So it would be useful to have a special box.cfg option > ignore_space_formats. It would allow to start an instance on > the spaces with malformed formats, fix them, create a snapshot > and then start with the formats turned on. > > Closes #3605 > > @TarantoolBot document > Title: box.cfg option 'ignore_space_formats' > The option allows to turn off space formats validation before > the instance is started. Useful to fix malformed formats after > an upgrade from version < 1.7.5 to >= 1.7.5. > --- > Branch: https://github.com/tarantool/tarantool/tree/imeevma/gh-3605-ignore-space-formats-option > Issue: https://github.com/tarantool/tarantool/issues/3605 >