From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alyapunov@tarantool.org>
Received: from smtp15.mail.ru (smtp15.mail.ru [94.100.176.133])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 0A979469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  8 May 2020 19:29:09 +0300 (MSK)
References: <cover.1587948306.git.korablev@tarantool.org>
 <7965217ceed66d448cee453c690e8d91ba7a841b.1587948306.git.korablev@tarantool.org>
 <653509c4-55b0-a7cb-55ab-eb534a0e6421@tarantool.org>
 <20200507003617.GB9992@tarantool.org>
 <7b07eb55-340b-b2ca-231c-9feeffe32a3f@tarantool.org>
 <20200507221636.GA13970@tarantool.org>
From: Aleksandr Lyapunov <alyapunov@tarantool.org>
Message-ID: <cef57bb6-3b0e-ef5f-a1fd-7eb4dbf08cec@tarantool.org>
Date: Fri, 8 May 2020 19:29:08 +0300
MIME-Version: 1.0
In-Reply-To: <20200507221636.GA13970@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH v3 3/3] vinyl: clean-up write
 iterator if vy_task_write_run() fails
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org


On 5/8/20 1:16 AM, Nikita Pettik wrote:
>
> I explored that patch. It is not backported to 1.10 (obviously) since
> other changes except for additional clean-up in vy_write_iterator_start()
> look like refactoring (we push to 1.10 only bug fixes). It can't be
> cherry-picked now since code is bit different and 1.10 lacks some
> features (like heap helpers to determine whether heap node is linked or
> not). So I suggest to leave my patch as is for 1.10 branch and backport
> test case to master branch.
>   
I think it's OK.