From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D3A681944AC7; Tue, 13 Jan 2026 18:34:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D3A681944AC7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1768318490; bh=f9wyNldr/hhavklM40PeYumX2FRCg7lXizDcS+R5vcw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=cYxYjO8sdWp7tlZeAZ8Jjn+BC/dR1FMSplR/j03XS6Ln/r9FADVrstympO3m+XiBA AsVdtpd1NIx5lObWjer3/lRcfLdL6Rr07tGPrj5fttxA6vslz7rQ7x8KCbJhsemAy/ w4AlgpwVqqWUure5iriDE4BslPchEjDXTof23D2A= Received: from send126.i.mail.ru (send126.i.mail.ru [89.221.237.221]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 38A911944AC5 for ; Tue, 13 Jan 2026 18:34:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 38A911944AC5 Received: by exim-smtp-7b4fb89df9-vzw4j with esmtpa (envelope-from ) id 1vfgPr-000000008nu-1cCi; Tue, 13 Jan 2026 18:34:43 +0300 Content-Type: multipart/alternative; boundary="------------fG0utEZ66qxEzLMpXN9ExAmc" Message-ID: Date: Tue, 13 Jan 2026 18:34:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <3a9ba410-3874-4609-8598-d69de057d0c1@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD979975AF0D777FEBD136B1DE29D0A14186819F7335A1BEA2E182A05F53808504011016D0F6F8DCF4E3DE06ABAFEAF6705025B2C44D6D47871B2CDCC1786F964BC59C33E53B579784F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A3589DC202DD7369EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637ECAF4C2CEE0D0B2F8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B256BBE30B775FB0D82E070BE324C7D3C460A7D6025097FDDDF6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249957A4DEDD2346B42CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0A29E2F051442AF778941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD269176DF2183F8FC7C0CAB4775CB929E3BB7B076A6E789B0E97A8DF7F3B2552694AD5FFEEA1DED7F25D49FD398EE364050F9647ADFADE5905B1F41620B44FB51B7DB3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BB662CFBDBA8F60F475ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A569B852DEA65768585002B1117B3ED696F400368C8E460ABDB2920F75BA9A967F823CB91A9FED034534781492E4B8EEADDFC043C56F70D752BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659C1A0B3855452DA1CF106E216456373F5529A1C162DF035D1C61E31F08FBE803990886CC70844F4CDB8341EE9D5BE9A0A86B8E6485A84A8F01AF9E8710121A3892AC2E8B288F0E7F88CD93680B12512CF4C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVVt0N+pdRHOZ/+jlpYtj2PY= X-Mailru-Sender: 811C44EDE0507D1FFB106D83BFFB684F18351A6FF886DBF920C74B26AAFF934594FA253745BB6D6A91FF3BB0DE77BD3F645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 31/41] perf: add scimark-mc in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------fG0utEZ66qxEzLMpXN9ExAmc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, LGTM then Sergey On 1/3/26 09:05, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Please consider my answer below. > > On 02.01.26, Sergey Bronnikov wrote: >> Hi, Sergey! >> >> thanks for the patch! LGTM with a minor comment. >> >> Sergey >> >> On 12/26/25 12:18, Sergey Kaplun wrote: >>> This patch adds the aforementioned test with the use of the benchmark >>> framework introduced before. The default arguments are adjusted >>> according to the amount of cycles in the file. >>> The arguments to the script can be provided in the command line run. >>> >>> Checks are omitted since they were not present in the original suite, >>> plus the precise result value depends on the input parameter. >>> --- >>> perf/LuaJIT-benches/scimark-mc.lua | 19 +++++++++++++++++++ >>> 1 file changed, 19 insertions(+) >>> create mode 100644 perf/LuaJIT-benches/scimark-mc.lua >>> >>> diff --git a/perf/LuaJIT-benches/scimark-mc.lua b/perf/LuaJIT-benches/scimark-mc.lua >>> new file mode 100644 >>> index 00000000..d26b6e48 >>> --- /dev/null >>> +++ b/perf/LuaJIT-benches/scimark-mc.lua >>> @@ -0,0 +1,19 @@ >>> +local bench = require("bench").new(arg) >>> + >>> +local cycles = tonumber(arg and arg[1]) or 15e7 >> Do we want to add this to the usage? > I suppose there is no need for it. > This still may be done if you are exploring the benchmark behaviour. But > you will read its sources in this case anyway. > >>> + >>> +local benchmark >>> +benchmark = { >>> + name = "scimark_mc", >>> + -- XXX: The description of tests for the function is too >>> + -- inconvenient. >>> + skip_check = true, >>> + payload = function() >>> + local flops = require("scimark_lib").MC()(cycles) >>> + benchmark.items = flops >>> + end, >>> +} >>> + >>> +bench:add(benchmark) >>> + >>> +bench:run_and_report() --------------fG0utEZ66qxEzLMpXN9ExAmc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

LGTM then

Sergey

On 1/3/26 09:05, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Please consider my answer below.

On 02.01.26, Sergey Bronnikov wrote:

Hi, Sergey!

thanks for the patch! LGTM with a minor comment.

Sergey

On 12/26/25 12:18, Sergey Kaplun wrote:

This patch adds the aforementioned test with the use of the benchmark
framework introduced before. The default arguments are adjusted
according to the amount of cycles in the <scimark-2010-12-20.lua> file.
The arguments to the script can be provided in the command line run.

Checks are omitted since they were not present in the original suite,
plus the precise result value depends on the input parameter.
---
  perf/LuaJIT-benches/scimark-mc.lua | 19 +++++++++++++++++++
  1 file changed, 19 insertions(+)
  create mode 100644 perf/LuaJIT-benches/scimark-mc.lua

diff --git a/perf/LuaJIT-benches/scimark-mc.lua b/perf/LuaJIT-benches/scimark-mc.lua
new file mode 100644
index 00000000..d26b6e48
--- /dev/null
+++ b/perf/LuaJIT-benches/scimark-mc.lua
@@ -0,0 +1,19 @@
+local bench = require("bench").new(arg)
+
+local cycles = tonumber(arg and arg[1]) or 15e7

Do we want to add this to the usage?

I suppose there is no need for it.
This still may be done if you are exploring the benchmark behaviour. But
you will read its sources in this case anyway.


+
+local benchmark
+benchmark = {
+  name = "scimark_mc",
+  -- XXX: The description of tests for the function is too
+  -- inconvenient.
+  skip_check = true,
+  payload = function()
+    local flops = require("scimark_lib").MC()(cycles)
+    benchmark.items = flops
+  end,
+}
+
+bench:add(benchmark)
+
+bench:run_and_report()


    

  
  


--------------fG0utEZ66qxEzLMpXN9ExAmc--