From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 689687030F; Fri, 15 Jan 2021 15:54:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 689687030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610715277; bh=Se+9Qp27zrmdTNTe3XmDo9k8b0FJLukcUJUDfBlcgKE=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=o6m1buuuZGhENDrxztRcKOqLzdzYiZNsxj95MsMvuj3aIQLswoD8lSZ09OgfKTBq5 Q2jox9N7wi/rcEP33obQrIosgI3WcGZ91Q2pl+eN3dxkXRnwhSGbsF+Jcjt5lAg+7Y jaHjp7wk/VIHsgNytRXidiCi0A4obsBVIX/5l05I= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0268B7030F for ; Fri, 15 Jan 2021 15:54:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0268B7030F Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1l0Ocd-00055v-Tp; Fri, 15 Jan 2021 15:54:36 +0300 To: Serge Petrenko , tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org References: <82365527bf3aefe026e0c0e4d93f3acbb882391c.1610709207.git.sergeyb@tarantool.org> Message-ID: Date: Fri, 15 Jan 2021 15:54:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CDAC53986DC5FB1AB1465E8C05863AF8B800894C459B0CD1B904E4C8C0D2F62AB875301F5E2568225502587BF5ABB16BCD872416D062D2E1BD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7EED5D2FAB4CEB1EDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C867FEFF36BCDF178638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC6FD3D10E84685BD8488AE3675A81A1C57569F8B2315E7F68389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0A3E989B1926288338941B15DA834481F9449624AB7ADAF3735872C767BF85DA29E625A9149C048EE1B544F03EFBC4D57F43AACC0BCEB26324AD6D5ED66289B524E70A05D1297E1BB35872C767BF85DA227C277FBC8AE2E8B3FA57FEE4CEE42B075ECD9A6C639B01B4E70A05D1297E1BBC6867C52282FAC85D9B7C4F32B44FF57285124B2A10EEC6C00306258E7E6ABB4E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5CE021B5E0736309A1A24BB259089A798DB2E538AF93E7F96D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758F9E841AEAEC4F2C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AC6E62257D6CD1C93C44EFAF871079653FAFD43EA3D16526A8BB457FE8BE7A02DE91B7F24AF285C01D7E09C32AA3244CCC2067BEBB89F1C090BB2306B7530B758894E9C85370243EFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojT/h6YDL0UQ6UWcoHgtoedw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822B3D9C71DCB310B1393A8FB6932B59AAFDD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] luacheck: fix warnings in test/box X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for review! On 15.01.2021 15:39, Serge Petrenko wrote: > > > 15.01.2021 14:22, sergeyb@tarantool.org пишет: >> From: Sergey Bronnikov >> >> Follows up #5455 >> --- > > Thanks for the  patch! > LGTM. > One question below. > > >> test/box/gh-5304-insert_during_recovery.lua  | 10 +++++----- >>   test/box/gh-5304-replace_during_recovery.lua |  1 + >>   2 files changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/test/box/gh-5304-insert_during_recovery.lua >> b/test/box/gh-5304-insert_during_recovery.lua >> index ac6eef342..c8b6c5cfb 100644 >> --- a/test/box/gh-5304-insert_during_recovery.lua >> +++ b/test/box/gh-5304-insert_during_recovery.lua >> @@ -1,24 +1,24 @@ >>   #!/usr/bin/env tarantool >>   -function none(old_space, new_space) >> +local function none(old_space, new_space) -- luacheck: ignore > > What's "luacheck: ignore" comment for? Haven't you fixed the warning > already by introducing `local` ? > There are two warnings here. First one about global scope, that was fixed with "local" and second one about unused parameters, that was suppressed by "luacheck: ignore". >>   end >>   -function trigger_replace(old_space, new_space) >> +local function trigger_replace(old_space, new_space) -- luacheck: >> ignore >>       box.space.temp:replace({1}) >>       box.space.loc:replace({1}) >>   end >>   -function trigger_insert(old_space, new_space) >> +local function trigger_insert(old_space, new_space) -- luacheck: ignore >>       box.space.temp:insert({1}) >>       box.space.loc:insert({1}) >>   end >>   -function trigger_upsert(old_space, new_space) >> +local function trigger_upsert(old_space, new_space) -- luacheck: ignore >>       box.space.temp:upsert({1}, {{'=', 1, 4}}) >>       box.space.loc:upsert({1}, {{'=', 1, 4}}) >>   end >>   -trigger = nil >> +local trigger = nil >>     if arg[1] == 'none' then >>       trigger = none >> diff --git a/test/box/gh-5304-replace_during_recovery.lua >> b/test/box/gh-5304-replace_during_recovery.lua >> index d6a7099ac..8b9a657af 100644 >> --- a/test/box/gh-5304-replace_during_recovery.lua >> +++ b/test/box/gh-5304-replace_during_recovery.lua >> @@ -2,6 +2,7 @@ >>     if arg[1] == 'replace' then >>       box.ctl.on_schema_init(function() >> +        -- luacheck: ignore >>           box.space._index:on_replace(function(old_space, new_space) >>               if new_space[1] == 512 then >>                   box.space.test:on_replace(function(old_tup, new_tup) >