From: Serge Petrenko <sergepetrenko@tarantool.org> To: Cyrill Gorcunov <gorcunov@gmail.com>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Cc: tml <tarantool-patches@dev.tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] raft: use vclock_map_t for voting tracking Date: Fri, 6 Nov 2020 13:28:01 +0300 [thread overview] Message-ID: <ce02c2a0-cb2c-236e-4fa4-46d0e98a9f8c@tarantool.org> (raw) In-Reply-To: <20201106083724.508438-1-gorcunov@gmail.com> 06.11.2020 11:37, Cyrill Gorcunov пишет: > We've VCLOCK_MASK constant which limits the number of > regular nodes in a replication cluster. This limit is > bound to the vclock_map_t bitset type. Thus when we're > tacking voting process in Raft node we better use this > type for vote_mask member (otherwise it is a room for > error if we ever change VCLOCK_MASK and extend the width > of a bitset). > > Suggested-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> Hi! Thanks for the patch! LGTM. > --- > branch gorcunov/raft-vote-mask > > src/box/raft.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/box/raft.h b/src/box/raft.h > index 8293d7410..0e7fe0e85 100644 > --- a/src/box/raft.h > +++ b/src/box/raft.h > @@ -33,6 +33,7 @@ > #include <stdbool.h> > #include "tarantool_ev.h" > #include "trigger.h" > +#include "vclock.h" > > #if defined(__cplusplus) > extern "C" { > @@ -146,7 +147,7 @@ struct raft { > * Bit 1 on position N means that a vote from instance with ID = N was > * obtained. > */ > - uint32_t vote_mask; > + vclock_map_t vote_mask; > /** Number of votes for this instance. Valid only in candidate state. */ > int vote_count; > /** State machine timed event trigger. */ -- Serge Petrenko
next prev parent reply other threads:[~2020-11-06 10:28 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-06 8:37 Cyrill Gorcunov 2020-11-06 10:28 ` Serge Petrenko [this message] 2020-11-13 22:42 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ce02c2a0-cb2c-236e-4fa4-46d0e98a9f8c@tarantool.org \ --to=sergepetrenko@tarantool.org \ --cc=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] raft: use vclock_map_t for voting tracking' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox