From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4BC01270B4 for ; Tue, 20 Aug 2019 11:26:06 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UA94AAs5It4A for ; Tue, 20 Aug 2019 11:26:06 -0400 (EDT) Received: from smtp21.mail.ru (smtp21.mail.ru [94.100.179.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B674F27093 for ; Tue, 20 Aug 2019 11:26:05 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH] Enable support for NOTIFY_SOCKET on macOS References: <20190819082813.38237-1-m.melentiev@corp.mail.ru> <20190819201827.GA21602@atlas> From: "Maxim Melentiev" (Redacted sender "m.melentiev" for DMARC) Message-ID: Date: Tue, 20 Aug 2019 18:26:02 +0300 MIME-Version: 1.0 In-Reply-To: <20190819201827.GA21602@atlas> Content-Type: multipart/alternative; boundary="------------AC7E179B2FA7C9DB6CB35A07" Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Konstantin Osipov , tarantool-patches@freelists.org Cc: alexander.turenko@tarantool.org This is a multi-part message in MIME format. --------------AC7E179B2FA7C9DB6CB35A07 Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit It's quite complicated now: cmake WITH_SYSTEMD flag is also used to generate systemd units, tarantool-generator and other systemd related files. I think that support for NOTIFY_SOCKET should not be systemd-related, as it's enabled in runtime by envar and is disabled otherwise. On 19/08/2019 23:18, Konstantin Osipov wrote: >> -#if defined(WITH_SYSTEMD) > I don't think you should remove this ifdef at all. Simply enable > it on Mac OSX by default in cmake if it works there now. > --------------AC7E179B2FA7C9DB6CB35A07 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

It's quite complicated now: cmake WITH_SYSTEMD flag is also used to generate systemd units, tarantool-generator and other systemd related files.

I think that support for NOTIFY_SOCKET should not be systemd-related, as it's enabled in runtime by envar and is disabled otherwise.

On 19/08/2019 23:18, Konstantin Osipov wrote:

-#if defined(WITH_SYSTEMD)

I don't think you should remove this ifdef at all. Simply enable
it on Mac OSX by default in cmake if it works there now.

--------------AC7E179B2FA7C9DB6CB35A07--