From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp21.mail.ru (smtp21.mail.ru [94.100.179.250])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1D3CD4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 11 Feb 2020 02:25:03 +0300 (MSK)
References: <cover.1580841722.git.korablev@tarantool.org>
 <0a6143594e0279d19d3b760a75f0139dbd42dae8.1580841722.git.korablev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <cdc5ce0b-a4a8-77e0-92c2-35aedb1fe850@tarantool.org>
Date: Tue, 11 Feb 2020 00:25:01 +0100
MIME-Version: 1.0
In-Reply-To: <0a6143594e0279d19d3b760a75f0139dbd42dae8.1580841722.git.korablev@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/4] sql: refactor
 sqlVdbeMemNumerify()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Thanks for the patchset!

On 05/02/2020 17:19, Nikita Pettik wrote:
> Fix codestyle and comment; allow conversion from boolean to number
> (since it is legal to convert boolean to integer, and in turn number
> type completely includes integer type).
> 
> Part of #4233
> ---
>  src/box/sql/vdbeInt.h | 12 +++++++++++-
>  src/box/sql/vdbemem.c | 46 +++++++++++++++++++---------------------------
>  2 files changed, 30 insertions(+), 28 deletions(-)
> 
> diff --git a/src/box/sql/vdbeInt.h b/src/box/sql/vdbeInt.h
> index 1393f3fd2..a80a691e1 100644
> --- a/src/box/sql/vdbeInt.h
> +++ b/src/box/sql/vdbeInt.h
> @@ -533,7 +533,17 @@ mem_value_bool(const struct Mem *mem, bool *b);
>  
>  int mem_apply_integer_type(Mem *);
>  int sqlVdbeMemRealify(Mem *);
> -int sqlVdbeMemNumerify(Mem *);
> +
> +/**
> + * Convert @mem to NUMBER type, so that after conversion it has one

'@' is a command prefix in Doxygen. The word after '@' is considered
a command. I suppose you didn't mean command 'mem', but rather wanted
to mention a parameter called 'mem'. In that case I suggest '@a mem'.
We use '@a' usually, except some old files, which still can use '\a'
or something like this.