From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C7C201FAF6 for ; Wed, 24 Apr 2019 10:03:02 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7tLgnvrWTbEI for ; Wed, 24 Apr 2019 10:03:02 -0400 (EDT) Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 311811FD3F for ; Wed, 24 Apr 2019 10:03:02 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: check access rights of table in VIEW References: <3f7dd91795bf6154382cce7732a1016fc24ebcdc.1556108155.git.kshcherbatov@tarantool.org> <94baf90f-acd5-04ae-0bcd-8f800e6518c4@tarantool.org> From: Kirill Shcherbatov Message-ID: Date: Wed, 24 Apr 2019 17:02:59 +0300 MIME-Version: 1.0 In-Reply-To: <94baf90f-acd5-04ae-0bcd-8f800e6518c4@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Vladislav Shpilevoy On 24.04.2019 16:48, Vladislav Shpilevoy wrote: > Thanks for the patch! >> +test_run = require('test_run').new() > > 1. You do not use this object, so it can be omitted. > 2. You pass here box.cfg.listen directly, without splitting into > parts. > > Please, consider my review fixes below and on the branch: Looks good for me, thanks. Amend.