From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arkholga@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 20967469710
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 21 May 2020 18:33:10 +0300 (MSK)
References: <20200316121548.48251-1-arkholga@tarantool.org>
 <20200427170936.GO11314@tarantool.org>
From: Olga Arkhangelskaia <arkholga@tarantool.org>
Message-ID: <cc96d61a-7bc5-e001-2e23-bf5d784921af@tarantool.org>
Date: Thu, 21 May 2020 18:33:06 +0300
MIME-Version: 1.0
In-Reply-To: <20200427170936.GO11314@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH] cmake: set CMP0037 policy to NEW by
 default
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Igor! Thanks for the review.

I did not get Sasha's approach. However, according to cmake 
documentations name test in

add_custom_target can be used if the modules CTest or CPAck is enabled.

https://cmake.org/cmake/help/latest/policy/CMP0037.html?highlight=cmp0037

So we just need to use NEW behaviour and cmake 3.11 and above.

See:

-if(POLICY CMP0037)
-    cmake_policy(SET CMP0037 OLD)
-endif(POLICY CMP0037)
-

+ if(POLICY CMP0037)
+    cmake_policy(SET CMP0037 NEW)
+ endif(POLICY CMP0037)
+


27.04.2020 20:09, Igor Munkin пишет:
> Olya,
>
> Thanks for the patch! Unfortunately, the changes don't fix the
> problem[1]. Did you find the approach provided by Sasha[2] wrong?
>
> On 16.03.20, Olga Arkhangelskaia wrote:
>> Remove setting old CMP0037 policy explicitly, it may be
>> removed in later versions of cmake.
>>
>> Closes #3587
>> ---
>> Branches: https://github.com/tarantool/tarantool/tree/OKriw/gh-3587-CMP0037-OLD-cmake-deprecation-warning-full-ci
>>
>>   test/CMakeLists.txt | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
>> index 9b5df7dc5..61bf7d5e1 100644
>> --- a/test/CMakeLists.txt
>> +++ b/test/CMakeLists.txt
>> @@ -17,10 +17,6 @@ endfunction()
>>   add_compile_flags("C;CXX"
>>       "-Wno-unused-parameter")
>>   
>> -if(POLICY CMP0037)
>> -    cmake_policy(SET CMP0037 OLD)
>> -endif(POLICY CMP0037)
>> -
>>   add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/luajit-tap
>>       COMMAND ${CMAKE_COMMAND} -E create_symlink
>>           ${PROJECT_SOURCE_DIR}/third_party/luajit/test
>> -- 
>> 2.20.1 (Apple Git-117)
>>
> [1]: https://gitlab.com/tarantool/tarantool/-/jobs/472976392#L464
> [2]: https://github.com/tarantool/tarantool/issues/3587#issue-346204529
>