From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0515829D3D
	for <tarantool-patches@freelists.org>; Tue, 11 Sep 2018 03:21:59 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id R--0nHwa2Qh2 for <tarantool-patches@freelists.org>;
	Tue, 11 Sep 2018 03:21:58 -0400 (EDT)
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B697429D2A
	for <tarantool-patches@freelists.org>; Tue, 11 Sep 2018 03:21:58 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v1 3/3] sql: dissallow bindings
 for DDL
References: <cover.1535730218.git.kshcherbatov@tarantool.org>
 <cover.1535730218.git.kshcherbatov@tarantool.org>
 <5049d3e7b70b7091c51ac99fc64f14a07c879c8a.1535730218.git.kshcherbatov@tarantool.org>
 <EDD77E8A-40A8-4417-8EFC-CE245976B3D8@tarantool.org>
 <105d3104-aa3e-4834-ea31-fca817bad47e@tarantool.org>
 <661DC330-826B-41DC-A729-BBA9677CAD06@tarantool.org>
From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Message-ID: <cc3a12cd-b6c1-678a-88d1-cb657d1a0a77@tarantool.org>
Date: Tue, 11 Sep 2018 10:21:55 +0300
MIME-Version: 1.0
In-Reply-To: <661DC330-826B-41DC-A729-BBA9677CAD06@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>

> ‘''
> Could we keep previous error message? It looks satisfactory actually.
> The same for triggers: could we use message like
> “Failed to create trigger ‘…’: parameters prohibited in trigger definition”?
> Or present your persuasive arguments :)
> ‘’’
> 
> I ‘member that we discussed smth about error messages but really
> can’t recall exactly what. So, please, answer on this nit or fix it.
The previous error message was set elsewhere in other place, on resolve.
Now this is a part of parser that doesn't now, which AST does it compile. And this 
should be done uniformly.

> This test should be moved to test/sql/triggers.test.lua
> (Since this test is about checks only).
Ohm, okey. Separate tests per one ticket is a bigger evil for me.
As you wish. I've fixed it.