From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1B81E5BFDB5; Mon, 28 Aug 2023 16:15:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1B81E5BFDB5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693228557; bh=YW0XM0I1Ax9oO9DJSA1H3Zskohr2JmXQZIySztLU+Mk=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=eRF/kiBtT/5gXpe1PYMv8YHLqkAtgX8kamTKNVlFPhnWzFuno7VY20Yl7+RD3M81L KnTxYEUMP5vCrNpnvO6KE3x4uwYhaS+ZNWD4iQVNh+p/PlD7H+HdE/YitUly9TS+49 FUlp6gmBKpgL0jsgpZhoab1w2bHQAKrW1r3iCmbM= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 55C775BE742 for ; Mon, 28 Aug 2023 16:15:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 55C775BE742 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qac5z-0001qG-Kz; Mon, 28 Aug 2023 16:15:56 +0300 Message-ID: Date: Mon, 28 Aug 2023 16:15:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <20230815123215.510-1-skaplun@tarantool.org> In-Reply-To: <20230815123215.510-1-skaplun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9954329A9C7AF96E95E2F5ED1E806A3C3B70BEC1D068B2957182A05F538085040D6BA93EC49152800C7ED4F9D712B3D102D78BE3AFFD1D67C118F84BC2E08199B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7EED5D2FAB4CEB1EDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377CC130305260E47D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D81577EC4789712EDADC238DDC1D5E36FF117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC01CE49B20A463386A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FE5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C0FE3A47D6FA29121068655334FD4449CB33AC447995A7AD186D8C47C27EEC5E9FD5E8D9A59859A8B60A9A04DE7321024275ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A53FE742D655EA97574801DD7EC264080C3452F48D4EA611CDF87CCE6106E1FC07E67D4AC08A07B9B0457EE4B4996FC546CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF28BAB1D9857838E9B60EF65C56DAAB1E4D96CD0B355ED2A54D44521587C1A3EC8FF2D56E53A087285088795BE9012648607FE62E5A88A0813D43F3859DD3C9B1E48CAC7CA610320002C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrC6BcuK2ROzlRrvGEy7QUA== X-DA7885C5: 591EF6DBAFC1931D598512653F4733111BE596F7435F9D67287BD17F32C4B912262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986BE8EE4D974C81BB620E2DC4D8530E0535DD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix maxslots when recording BC_VARG, part 3. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey thanks for your fixes proposed in [1], I like your suggested changes. LGTM after fixing red CI, see in [2]. 1. https://lists.tarantool.org/tarantool-patches/ZOTXyLt2x9FcXCt6@root/ 2. https://github.com/tarantool/luajit/actions/runs/5950318637/job/16138150847 On 8/15/23 15:32, Sergey Kaplun wrote: > From: Mike Pall > > Thanks to Peter Cawley. > > (cherry-picked from commit abb27c7771947e082c9d919d184ad5f5f03e2e32) > > In case, when `BC_VARG` set the VARG slot to the non-top stack slot, > `maxslot` value was unconditionally set to the destination slot, so some > top slots may be omitted in the snapshot entry. Since these slots are > omitted, they are not restored correctly, when restoring from snapshot > for this side exit. > > This patch adds the check for the aforementioned case, to avoid maxslot > shrinking. >