From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A355441C5DA
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 27 Jun 2020 01:00:42 +0300 (MSK)
References: <cover.1592589312.git.sergepetrenko@tarantool.org>
 <46ed0cc08e6ecf7ee7c9250d9cdfc3d68aa5c764.1592589312.git.sergepetrenko@tarantool.org>
 <30f75001-3ecc-9d7f-9cba-88c824087f4e@tarantool.org>
 <ecb9c03f-0977-7395-c7c5-8780e95ec7db@tarantool.org>
 <bc71772b-76b7-88c1-0096-9b96d08483ea@tarantool.org>
 <c56a7c97-dd93-adff-5fbd-37b0d05ed7aa@tarantool.org>
 <aee710ff-535e-d5f3-6395-2c039a5be89e@tarantool.org>
 <6349f4ba-88c2-e6b4-1785-50e18dd5d010@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <cbd18b54-2e3d-47af-77d2-c28af235e4bd@tarantool.org>
Date: Sat, 27 Jun 2020 00:00:39 +0200
MIME-Version: 1.0
In-Reply-To: <6349f4ba-88c2-e6b4-1785-50e18dd5d010@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH 1/2] box: rework local_recovery to
 use async txn_commit
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>, sergos@tarantool.org, gorcunov@tarantool.org, lvasiliev@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

On 23/06/2020 10:39, Serge Petrenko wrote:
> 
> 23.06.2020 00:43, Vladislav Shpilevoy пишет:
>> I am looking at the commit which added on_write_failure.
>> Why can't we reuse on_rollback trigger? As we discussed,
>> we can pass whatever we want using txn->signature. So
>> for manual rollback we can set it to -1, for write failure
>> to -2, for limbo rollback to -3, for timeout to -4, etc.
>>
>> I am just afraid that +16 bytes for transaction object
>> may affect performance of the async transactions.
> 
> We can. I've just done it & dropped the additionnal commit
> 
> (the one that hacked the trigger removal in recovery.

We also can drop TXN_IS_ABORTED_BY_YIELD and reuse the signature
for this type of error too.