From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4BB93A04F58; Wed, 7 Feb 2024 11:14:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4BB93A04F58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707293647; bh=v1Yt/0cadYBrChPQ+lAqMJd1Vc93+jONNEPMtLdtyZs=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=fp4p1FnpSTu8xEz+9fTRbuunfUz+Wqad/TOLm8HgVdvc7c5urzNlt1d5xu+Rsnpdr w+lehTnWwum2skWyS7sDFT/x6zZ83TKULWMuX2jAEYy9fM+36cAwRPz1lhLTTcKgO8 iqIfeE/ZqW0EiX7CY54AE24ybqcUwF2LfTcrxokc= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [95.163.41.87]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E9F8056CD16 for ; Wed, 7 Feb 2024 11:14:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E9F8056CD16 Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1rXd4F-00000003IoU-3MEO; Wed, 07 Feb 2024 11:14:04 +0300 Message-ID: Date: Wed, 7 Feb 2024 11:14:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9DE389E818B66C7AEF74583E9BFD0023CE34868C9E9FB1C391867C24CE74E72BB5FE18E9CBFBE7C070FC4F5FE61FBDC8812D9F379CC21FF0BC73416446A646A9DE7E14E9202D77766074A40F52AF1438D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE727FD6E7FC3A8F857EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063744E972A96E850310EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B73AB1701401CD8719007C615907E97FFB81B8AB13EF3CAFD2FA088BDA95C1CBFA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3ED8438A78DFE0A9E117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF949FAA99599A9AB0BA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B6F562597386E28FBF76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C224952D31B9D28593E51E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6ACFD5AC65D14EB01089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5D37AD4D47FEA4C7D5002B1117B3ED69612F60E32DE234768E20DC3F561CE4150823CB91A9FED034534781492E4B8EEAD3B72D73EA5828B68BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF059972C5ED18C351D4CD9355B3BC0B25085EB7E12F12CD58B84743C7577570F7007A74C46802367A807D692F32DC70326391302818AD383E09FCCAB25326C43E5C30B17D846DEF005F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnPqUxtmMegqZQ== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458DE17937FECFFB422504BCEC120683F15CFE25127D531B888E1E1E2713883DFAD645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 00/26] More tests from LuaJIT-tests, part 1 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! thanks for the patch series again! LGTM On 1/29/24 13:45, Sergey Kaplun wrote: > This patchset enables most of the LuaJIT-tests related to FFI and > testing of C libraries (cpptest, ctest). More tests (from the > directory) will be enabled in the future series. > > FFI tests from the directory aren't enabled because of their > inconsistency, see also [1]. > > This increases coverage up to 92.5%, see here [2]. > > Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-9398-more-luajit-tests > Tarantool PR: https://github.com/tarantool/tarantool/pull/9603 > Related issues: > * https://github.com/tarantool/tarantool/issues/9398 > * https://github.com/tarantool/tarantool/issues/7834 > > [1]: https://github.com/LuaJIT/LuaJIT/pull/415 > [2]: https://coveralls.io/github/tarantool/luajit?branch=skaplun/gh-9398-more-luajit-tests > > Changes in the v2: > * Introduce the AddTestLib macro to avoid copy-pasting. It only adds a > target with necessary flags without setting any variables. > * is renamed to for consistency with > > * Rename some tests with uninformative naming (like `call_10i` -> > `10 int args`) > * Add adjusments of arguments for long calls (~10 arguments) to make them > comparable without changing test semantics. > * Fix some typos > > Sergey Kaplun (26): > cmake: introduce AddTestLib macro > test: prepare lauxilarily libs for LuaJIT-tests > test: separate LuaJIT helpers from ffi_util.inc > test: enable in LuaJIT-tests > test: enable in LuaJIT-tests > test: enable in LuaJIT-tests > test: enable in LuaJIT-tests > test: enable in LuaJIT-tests > test: enable in LuaJIT-tests > test: enable in LuaJIT-tests > test: enable > test: enable in LuaJIT-tests > test: enable in LuaJIT-tests > test: enable in LuaJIT-tests > test: enable in LuaJIT-tests > test: enable in LuaJIT-tests > test: enable in LuaJIT-tests > test: enable in LuaJIT-tests > test: enable in LuaJIT-tests > test: enable in LuaJIT-tests > test: enable LuaJIT test > test: enable LuaJIT test > test: enable LuaJIT test > test: enable LuaJIT test > test: enable LuaJIT test > test: enable LuaJIT test > > test/CMakeLists.txt | 3 + > test/LuaJIT-tests/CMakeLists.txt | 45 ++- > test/LuaJIT-tests/common/fails.lua | 3 + > test/LuaJIT-tests/common/ffi/checkfail.lua | 14 + > test/LuaJIT-tests/common/ffi/checktypes.lua | 15 + > test/LuaJIT-tests/common/ffi_util.inc | 23 -- > test/LuaJIT-tests/{misc => lang}/api_call.lua | 32 +- > .../{sysdep => lang}/catch_cpp.lua | 36 +- > .../{misc => lang}/catch_wrap.lua | 29 +- > test/LuaJIT-tests/lang/index | 4 + > test/LuaJIT-tests/lang/lightud.lua | 89 +++++ > test/LuaJIT-tests/lib/ffi/ffi_arith_ptr.lua | 13 +- > test/LuaJIT-tests/lib/ffi/ffi_bitfield.lua | 4 +- > test/LuaJIT-tests/lib/ffi/ffi_call.lua | 185 +++++----- > test/LuaJIT-tests/lib/ffi/ffi_callback.lua | 45 +-- > test/LuaJIT-tests/lib/ffi/ffi_const.lua | 4 +- > test/LuaJIT-tests/lib/ffi/ffi_convert.lua | 35 +- > test/LuaJIT-tests/lib/ffi/ffi_enum.lua | 11 +- > .../lib/ffi/ffi_gcstep_recursive.lua | 27 +- > test/LuaJIT-tests/lib/ffi/ffi_jit_arith.lua | 22 +- > test/LuaJIT-tests/lib/ffi/ffi_jit_call.lua | 70 ++-- > test/LuaJIT-tests/lib/ffi/ffi_jit_conv.lua | 70 ++-- > test/LuaJIT-tests/lib/ffi/ffi_lex_number.lua | 72 ++-- > test/LuaJIT-tests/lib/ffi/ffi_metatype.lua | 16 +- > test/LuaJIT-tests/lib/ffi/ffi_new.lua | 50 +-- > test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua | 106 +++--- > test/LuaJIT-tests/lib/ffi/ffi_parse_basic.lua | 251 ++++++------- > test/LuaJIT-tests/lib/ffi/ffi_parse_cdef.lua | 141 ++++---- > .../LuaJIT-tests/lib/ffi/ffi_parse_struct.lua | 335 +++++++++--------- > test/LuaJIT-tests/lib/ffi/ffi_tabov.lua | 12 - > test/LuaJIT-tests/lib/ffi/index | 18 + > test/LuaJIT-tests/misc/lightud.lua | 88 ----- > test/LuaJIT-tests/src/CMakeLists.txt | 17 + > .../src/{cpptest.cpp => libcpptest.cpp} | 4 +- > test/LuaJIT-tests/src/{ctest.c => libctest.c} | 4 +- > test/LuaJIT-tests/test.lua | 7 +- > .../PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt | 25 +- > test/cmake/AddTestLib.cmake | 28 ++ > test/tarantool-tests/CMakeLists.txt | 27 +- > test/tarantool-tests/ffi-tabov.test.lua | 27 ++ > 40 files changed, 1086 insertions(+), 921 deletions(-) > create mode 100644 test/LuaJIT-tests/common/fails.lua > create mode 100644 test/LuaJIT-tests/common/ffi/checkfail.lua > create mode 100644 test/LuaJIT-tests/common/ffi/checktypes.lua > rename test/LuaJIT-tests/{misc => lang}/api_call.lua (79%) > rename test/LuaJIT-tests/{sysdep => lang}/catch_cpp.lua (75%) > rename test/LuaJIT-tests/{misc => lang}/catch_wrap.lua (71%) > create mode 100644 test/LuaJIT-tests/lang/lightud.lua > delete mode 100644 test/LuaJIT-tests/lib/ffi/ffi_tabov.lua > delete mode 100644 test/LuaJIT-tests/misc/lightud.lua > create mode 100644 test/LuaJIT-tests/src/CMakeLists.txt > rename test/LuaJIT-tests/src/{cpptest.cpp => libcpptest.cpp} (96%) > rename test/LuaJIT-tests/src/{ctest.c => libctest.c} (99%) > create mode 100644 test/cmake/AddTestLib.cmake > create mode 100644 test/tarantool-tests/ffi-tabov.test.lua >