From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 20386283C4 for ; Fri, 22 Feb 2019 13:17:05 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Al90rCc8XZ21 for ; Fri, 22 Feb 2019 13:17:05 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D1F2226BBA for ; Fri, 22 Feb 2019 13:17:04 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH] sql: inherit global parameters for vinyl spaces References: <20190220145340.5402-1-korablev@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Fri, 22 Feb 2019 21:17:01 +0300 MIME-Version: 1.0 In-Reply-To: <20190220145340.5402-1-korablev@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Nikita Pettik , Kirill Yukhin LGTM. On 20/02/2019 17:53, Nikita Pettik wrote: > It is possible to create vinyl tables, if pragma sql_default_engine is > set to corresponding engine. However, such spaces don't inherit global > vinyl-specific options which can be set by box.cfg{}. Lets fix it and > during encoding of index options fetch appropriate configurations from > cfg. > > Closes #3912 > --- > Branch: https://github.com/tarantool/tarantool/tree/np/gh-3912-sql-vinyl-inherit-params > Issue: https://github.com/tarantool/tarantool/issues/3912 >