From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 0D4E14696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  1 May 2020 20:00:58 +0300 (MSK)
From: Oleg Babin <olegrok@tarantool.org>
References: <cover.1588292014.git.v.shpilevoy@tarantool.org>
 <d099adade84511ce90fdffe3ec3d0f2e2499db2d.1588292014.git.v.shpilevoy@tarantool.org>
Message-ID: <cb0944b2-4259-12c9-6369-de28b581017a@tarantool.org>
Date: Fri, 1 May 2020 20:00:51 +0300
MIME-Version: 1.0
In-Reply-To: <d099adade84511ce90fdffe3ec3d0f2e2499db2d.1588292014.git.v.shpilevoy@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH vshard 4/7] test: clear route map,
	respecting statistics
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch. LGTM.

On 01/05/2020 03:16, Vladislav Shpilevoy wrote:
> Router's test sometimes need to wipe the route map. Simple reset
> it to {} may produce unexpected results, because route map is not
> just a table. It is also statistics in replicaset objects.
> 
> Inconsistent statistics may lead to failing tests in surprising
> places. That becomes even more true with forthcoming patches,
> which rework the statistics a little bit so it actually affects
> something inside the router.
> 
> Part of #210