From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 06D6F6EC59; Wed, 10 Mar 2021 16:00:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 06D6F6EC59 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615381224; bh=YNq7lVANEvgbc6fjhpe/ezavYxp/A1JEvxz6bedfXPE=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=QTbBShLRh/kC3q4WD/gU6fpP6WRMW4k4bN0MMgI4nTymdqP4Og0D01I5OfUmWm/FC G5VW2wSiGSWH45MUHlsrqktXcA1PeTBcBvlyN041fileYdjH1Nj33wrL5+y5+ElHkr P3sqYqTwqTSoB6jE6HN0Lw2bymv6Bc3H6Y73WSPM= Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [94.100.177.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A52206EC59 for ; Wed, 10 Mar 2021 16:00:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A52206EC59 Received: by smtp30.i.mail.ru with esmtpa (envelope-from ) id 1lJyRp-0003uO-Jf; Wed, 10 Mar 2021 16:00:22 +0300 To: Leonid Vasiliev , Alexander Turenko References: <6d33f734-6cca-ba33-0bca-6fce61d373cf@tarantool.org> Message-ID: Date: Wed, 10 Mar 2021 16:00:20 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <6d33f734-6cca-ba33-0bca-6fce61d373cf@tarantool.org> Content-Type: multipart/alternative; boundary="------------2B475F9F7AFDD17CD9014CEB" Content-Language: ru X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69B9676070C5F64E418DB309FBA590CF44700894C459B0CD1B9C6AAE4023E9679BEE2A5CDE14601398C1D91ADCA0AFDC907EFBA94EB484632BD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F1942E6D70B4A2F0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637645995A778B1BFFAEA1F7E6F0F101C674E70A05D1297E1BBC6CDE5D1141D2B1CDA32AD85A0B8150F9702C3587C131D5CCA4D01E16B4086D49FA2833FD35BB23D9E625A9149C048EE33AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAE9A1BBD95851C5BA471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FCA950FB625D0211653AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F7900637E6305F9712AB413BD81D268191BDAD3D698AB9A7B718F8C442539A7722CA490C13377AFFFEAFD26923F8577A6DFFEA7CC1948A84299AD5C693EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B6B4612C9E9B341BF4089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E7028C9DFF55498CEFB0BD9CCCA9EDD067B1EDA766A37F9254B7 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46DE2B93EA33B711681355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A5112AA07507BC999B38F116BBE7808AE3EDA6E42F0F058907D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3473457D764E1CDE77794368E66952ABA6C6943F800A33EFA150E865838E1E962106AAD4AA37A634D91D7E09C32AA3244C5C85DCF3D85C3051AA71041F534074511DD47778AE04E04D927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojsR8tyFmO15ND0GpM/BBppw== X-Mailru-Sender: 49D287FBCBBF3A5C86449ED72883D43AD31165F1EAD8CB97EC1336003E765792C479C2914A57FB1F2325CE592137BF811458020726E2BC9F60B790B42577D741D24DB76E211E293F7402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCHv3 0/2] lua: fix tarantool -e always enters interactive mode X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Artem via Tarantool-patches Reply-To: Artem Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------2B475F9F7AFDD17CD9014CEB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hi, thank you for the review! 05.03.2021 15:44, Leonid Vasiliev пишет: > Hi! > Please, add changelogs according to `doc/changelogs.md`. Done. Added changelogs/unreleased/fix-tarantool-e-option.md > > On 3/4/21 12:15 PM, Artem Starshov wrote: >> Issue: https://github.com/tarantool/tarantool/issues/5040 >> Branch: >> https://github.com/tarantool/tarantool/tree/artemreyt/gh-5040-interactive-mode-bug >> CI: https://github.com/tarantool/tarantool/runs/2029377964 >> >> Changes in v3: >>    * core: >>      - add case-insensetive value for boolean error injection; >>      - add more tests for setting error injections; >>      - few refactored things (80 line width, alignment and etc.); >>      - add release_disable for test; >>      - add reference to test-run issue in commit message; >>      - now, it is able to set errinjs via env ONLY in Debug mode. >>    * lua: >>      - some refactoring (name of variables, 80 line-width..); >>      - add release_disable for test; >>      - add reference to test-run issue in commit message; >>      - add "errinj" to the name of the test; >>      - add comments to source code. >> >> Artem Starshov (2): >>    core: add setting error injections via env >>    lua: fix tarantool -e always enters interactive mode >> >>   src/lib/core/errinj.c                         |  30 +++++ >>   src/lib/core/errinj.h                         |   6 + >>   src/lua/init.c                                |  27 +++- >>   src/main.cc                                   |   3 + >>   ...5040-inter-mode-isatty-via-errinj.test.lua | 126 ++++++++++++++++++ >>   test/app-tap/suite.ini                        |   1 + >>   .../errinj_set_with_enviroment_vars.test.lua  |  29 ++++ >>   ...errinj_set_with_enviroment_vars_script.lua |  34 +++++ >>   test/box-tap/suite.ini                        |   1 + >>   test/box/errinj.result                        |   1 + >>   10 files changed, 254 insertions(+), 4 deletions(-) >>   create mode 100755 >> test/app-tap/gh-5040-inter-mode-isatty-via-errinj.test.lua >>   create mode 100755 >> test/box-tap/errinj_set_with_enviroment_vars.test.lua >>   create mode 100644 >> test/box-tap/errinj_set_with_enviroment_vars_script.lua >> --------------2B475F9F7AFDD17CD9014CEB Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

Hi, thank you for the review!

05.03.2021 15:44, Leonid Vasiliev пишет:
Hi!
Please, add changelogs according to `doc/changelogs.md`.
Done. Added changelogs/unreleased/fix-tarantool-e-option.md

On 3/4/21 12:15 PM, Artem Starshov wrote:
Issue: https://github.com/tarantool/tarantool/issues/5040
Branch: https://github.com/tarantool/tarantool/tree/artemreyt/gh-5040-interactive-mode-bug
CI: https://github.com/tarantool/tarantool/runs/2029377964

Changes in v3:
   * core:
     - add case-insensetive value for boolean error injection;
     - add more tests for setting error injections;
     - few refactored things (80 line width, alignment and etc.);
     - add release_disable for test;
     - add reference to test-run issue in commit message;
     - now, it is able to set errinjs via env ONLY in Debug mode.
   * lua:
     - some refactoring (name of variables, 80 line-width..);
     - add release_disable for test;
     - add reference to test-run issue in commit message;
     - add "errinj" to the name of the test;
     - add comments to source code.

Artem Starshov (2):
   core: add setting error injections via env
   lua: fix tarantool -e always enters interactive mode

  src/lib/core/errinj.c                         |  30 +++++
  src/lib/core/errinj.h                         |   6 +
  src/lua/init.c                                |  27 +++-
  src/main.cc                                   |   3 +
  ...5040-inter-mode-isatty-via-errinj.test.lua | 126 ++++++++++++++++++
  test/app-tap/suite.ini                        |   1 +
  .../errinj_set_with_enviroment_vars.test.lua  |  29 ++++
  ...errinj_set_with_enviroment_vars_script.lua |  34 +++++
  test/box-tap/suite.ini                        |   1 +
  test/box/errinj.result                        |   1 +
  10 files changed, 254 insertions(+), 4 deletions(-)
  create mode 100755 test/app-tap/gh-5040-inter-mode-isatty-via-errinj.test.lua
  create mode 100755 test/box-tap/errinj_set_with_enviroment_vars.test.lua
  create mode 100644 test/box-tap/errinj_set_with_enviroment_vars_script.lua

--------------2B475F9F7AFDD17CD9014CEB--