From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1DF905630B3; Tue, 1 Aug 2023 12:56:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1DF905630B3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1690883770; bh=sAX1wOFOGZCrkOgNe64f/YrTmJunacr0l7qYzRMH960=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=nU59ap6X0ru45OtiwpPFnsg20T+OsAbWO01Buyu/of5f3JZnfd2MYxvm9omso0iiu QnULrGcAIAdHqXtEhof/tXyh+RV+dhTKCFV6Us+xzCw1wM2uVy075rxm4WgR4Vg8TM eSdmz9mFWzwpDNL5DILFJ5bqUBBB+k2Be7nFfgPw= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [95.163.41.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C5AB8561C88 for ; Tue, 1 Aug 2023 12:56:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C5AB8561C88 Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1qQm6q-007HhV-6x; Tue, 01 Aug 2023 12:56:08 +0300 Message-ID: Date: Tue, 1 Aug 2023 12:56:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Maxim Kokryashkin , Sergey Bronnikov Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org References: <6426e58a9a72691ccffc84001c21e363c8da6312.1690300762.git.sergeyb@tarantool.org> <5t3vejxwlcpd3fczyenum4527mtwtmt6qd4agwrxhnkt3zdtob@62fmw5pdbhqg> In-Reply-To: <5t3vejxwlcpd3fczyenum4527mtwtmt6qd4agwrxhnkt3zdtob@62fmw5pdbhqg> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD920919EE866B1AD24143E17AC63C08B5DFFFAD119030B46DB00894C459B0CD1B94C12168046F7CDBD6133A1BB7B43D38629429DFB688133682D8445145E24918E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7544B1CCE26E01C74EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637976142D429C486548638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B3A2266FA874491D7D8E7DB829ECC65A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520B28585415E75ADA9618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B1A68A47777D5C6D9CD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3AD0E433DBF1FBFA39735652A29929C6CC4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB861051D4BA689FC2E808ACE2090B5E1725E5C173C3A84C34964A708C60C975A089D37D7C0E48F6C8AA50765F7900637EC3198ECE464ADAEEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5F0FC415715C12EEDD3449D68CFF4A72222B15291B54EEF27F87CCE6106E1FC07E67D4AC08A07B9B0CF7CD7A0D5AA5F25CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D343DCFC3BEDFB0242D4C217B1A8FBD41888B2D3D54179631A911192169890965A7A9E06FB16EA3B5191D7E09C32AA3244CE1870C83646FB3A20B2D27D2BC961369F26BFA4C8A6946B8BAD658CF5C8AB4025DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxgaGEV50waJ6JqQ9yha01w== X-Mailru-Sender: 49D287FBCBBF3A5C10E199891D96F069711396501503E1AF8041F381FA5307345DA019BDE6EBFE7F645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] Fix embedded bytecode loader. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Max thanks for review! see my comments On 7/31/23 15:01, Maxim Kokryashkin via Tarantool-patches wrote: > Hi, Sergey! > Thanks for the patch! > Please consider my comments below. > > On Tue, Jul 25, 2023 at 07:36:24PM +0300, Sergey Bronnikov via Tarantool-patches wrote: >> From: sergeyb@tarantool.org >> >> (cherry-picked from commit 820339960123dc78a7ce03edf53fcf4fdae0e55d) >> >> Original problem is specific for x32 and is as follows: when a chunk > Typo: s/Original/The original/ > Typo: s/for x32/to x32/ Fixed. >> with bytecode library is loaded into memory, and the address is higher > Typo: s/with bytecode/with a bytecode/ Fixed. >> than 0x80000100, the LexState->pe, that contains an address of the end > Typo: s/the LexState/LexState/ Fixed. >> of bytecode chunk in the memory, will wrap around and become smaller > Typo: s/of bytecode/of the bytecode/ Fixed. >> than address in LexState->p, that contains an address of the beginning > Typo: s/than address/than the address/ Fixed. >> of bytecode chunk in the memory. In bcread_fill() called by >> bcread_want(), memcpy() is called with a very large size and causes bus >> error on x86 and segmentation fault on ARM android. > Typo: s/android/Android/ Fixed. >> The problem cannot be reproduced on platforms supported by Tarantool >> (ARM64, x86_64), so test doesn't reproduce a problem without a patch and >> tests patch partially. > Typo: s/tests the patch/ Fixed. > > Well, I've tried to run that test on x32 machine, and nothing happened. > I think we should backport this patch without tests then, since this > test seems irrelevant to the problem. What do you think? It is relevant, because covers a part of the patch. > > Also, it is kinda strange, that you are talking about a test in a patch > without any tests. You need to either mention that the test is present in > the next commit, or move that test here. I'll update commit message, thanks.