From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 911D5257AA for ; Mon, 18 Jun 2018 15:22:12 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SmvGB9a_VWu5 for ; Mon, 18 Jun 2018 15:22:12 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 505B325787 for ; Mon, 18 Jun 2018 15:22:12 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v3 09/10] sql: move Triggers to server References: <45ff716a-8295-50d8-f317-cc28f9d0dba4@tarantool.org> <0f277954-4d97-2896-7e4f-a3d78b87c4d1@tarantool.org> From: Kirill Shcherbatov Message-ID: Date: Mon, 18 Jun 2018 22:22:10 +0300 MIME-Version: 1.0 In-Reply-To: <0f277954-4d97-2896-7e4f-a3d78b87c4d1@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: "v.shpilevoy@tarantool.org" Let's push it to the next review step) > 1. Please, start a sentence with capital letter and finish > with dot. > 2. Put here link to the issue of the form: --- test crash on error.injection +---- +---- gh-3273: Move SQL TRIGGERs into server. +---- > 3. I have pushed some fixes in a separate commit. Please, > look and squash. After the patch will be LGTM. Ok, Tnx!