From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 87E246F3C4; Tue, 11 May 2021 23:13:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 87E246F3C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620763986; bh=oDnsaC6QQhKk2IMqfC80NLWT7TS/NYrRnkG3yC54pR0=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=DkmE2Bq2HMyjvVU+4TwAsSL1C5KxZxR5uKbXPEH30Jcx7KPBKn+D8K4NX9SibzWMI tZmUeoiPD9RXVNXMeCepZ5ZmPPrWDVfX8ll6rtj3eTgYP+PhHhxtRfgCu3wf7HdEnn m8SFAJAdj+BIwOkR33LMFlU737ZXM1ikfYxFaTU0= Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2A3546F3C4 for ; Tue, 11 May 2021 23:13:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2A3546F3C4 Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1lgYkY-0008G4-UQ; Tue, 11 May 2021 23:13:03 +0300 To: Cyrill Gorcunov , tml References: <20210504155819.290874-1-gorcunov@gmail.com> Message-ID: Date: Tue, 11 May 2021 22:13:01 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210504155819.290874-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95978C26455E69BE022900C3053DBED76BEB47C8A8E1FDA50182A05F5380850405257E5B215D167AC7111CB1D6106CC0D1265090C2122E75233B5A573544408C6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7ED971EE68B26EF8CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B323FE155BC226618638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B278388E13C65CD175715E1606D0B4BDF9E695ED7F9A6C896ED2E47CDBA5A96583C09775C1D3CA48CF17B107DEF921CE79117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE72D6F5946B5438EA6D32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C0FE699BDBDAE2D9AECD04E86FAF290E2D7E9C4E3C761E06A71DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B66F6A3E018CF4DC80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824A2A04A2ABAA09D25379311020FFC8D4ADD5B4F933BB674B521C12D4EB8363D4B3 X-C1DE0DAB: 0D63561A33F958A531D4789B1BCCB358106F19FAA67AB93E5C9DEF9C0ABB2F84D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348E5EF936B2E46EBA3ED66BC1E14A8B859BFA591C2C3A12F91E01CBD160E1954666EB86DC10C9D13C1D7E09C32AA3244C91583B4DA9F4EBD39B0E5B1ECE15F8A93FD9C8CA1B0515E0927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPN2Bz4bQWZvZvG+WhPEDmA== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA3110BD56533F621B63E2519DDF55BCF9F8B620684AF384A2051A07784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 00/10] fix say_x format and rework fibers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Good job on the fixes, really! Although function lbox_fiber_statof() still uses lua_pushinteger(): ==================== static int lbox_fiber_statof(struct fiber *f, void *cb_ctx, bool backtrace) { struct lua_State *L = (struct lua_State *) cb_ctx; lua_pushinteger(L, f->fid); <<<<<<<< lua_newtable(L); ==================== And cord_on_yield() still uses %d for fid: ==================== lua_pushfstring(L, "fiber %d is switched while running the" " compiled code (it's likely a function with" " a yield underneath called via LuaJIT FFI)", fiber()->fid); ========= lua_pushfstring(L, "fiber %d is switched while running GC" " finalizer (i.e. __gc metamethod)", fiber()->fid); ==================== Please, fix these places too.