From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 915F146970F
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 24 Nov 2019 18:54:16 +0300 (MSK)
References: <cover.1574545667.git.i.kosarev@tarantool.org>
 <6e3ca8db565b415bd1a30ca1c52ea39fc9eb3976.1574545667.git.i.kosarev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <ca1692e6-bda1-dd2d-cd89-dbe40ba6df65@tarantool.org>
Date: Sun, 24 Nov 2019 16:54:13 +0100
MIME-Version: 1.0
In-Reply-To: <6e3ca8db565b415bd1a30ca1c52ea39fc9eb3976.1574545667.git.i.kosarev@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 4/4] test: stabilize quorum test
	conditions
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Ilya Kosarev <i.kosarev@tarantool.org>, tarantool-patches@dev.tarantool.org

Thanks for the patch!

> diff --git a/test/replication/quorum.result b/test/replication/quorum.result
> index ff5fa0150..939ce1e00 100644
> --- a/test/replication/quorum.result
> +++ b/test/replication/quorum.result
> @@ -64,6 +68,10 @@ box.info.ro -- true
>  ---
>  - true
>  ...
> +test_run:wait_cond(function() return box.space.test ~= nil end, 20)

Why do you need the second wait for the same condition?
box.space.test was not dropped before this line, it should
still exist.

The same about all the similar checks for space.test.