From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 11BBB6EC40; Mon, 5 Jul 2021 23:54:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 11BBB6EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625518475; bh=EjBELt+KhbmkXUD2jvP575/ECc2dyJ0sK3XKigI9ehQ=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ax7jcou9/kLDmM/Q3B+1qnbxO0HvjizsYalUKP75q3uMzeLQJO90orw8ytZBSAbWu wZUfAjzuqQYtV27szRJweNBxS8Na7bbaa+orFtEVGK126oMziQQdbbSqO8desl51Ou kyNwVMLBcC5cZmqzbxgZpS+LmHXc9e+RTd6c0UbY= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6CEAE6EC40 for ; Mon, 5 Jul 2021 23:54:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6CEAE6EC40 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1m0VbM-0003jA-Iy; Mon, 05 Jul 2021 23:54:01 +0300 To: Oleg Babin , tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org References: <1b0facbff8f285ec54c03a3ec68fca777f4828a3.1625177222.git.v.shpilevoy@tarantool.org> <2dc3ff07-5f6e-294f-670a-5dcc5948c839@tarantool.org> <6073e325-a77b-c5c1-8950-950f41c36ac3@tarantool.org> <7621af8d-7918-950d-4911-dec06cadb95b@tarantool.org> Message-ID: Date: Mon, 5 Jul 2021 22:53:59 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <7621af8d-7918-950d-4911-dec06cadb95b@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB703477AD6D36A6E3C7EF2853D6A1C7C1182A05F5380850400BAAAD99E337B4EAA25301F2910B8B326A7F2795D40252FCDA7388A4F80D8623 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637670E1B164B70895C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84A59610EEEFFED0290F719F357E24EE0117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8883BAB8B32E402CA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520B28585415E75ADA9F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A1DCCEB63E2F10FB089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831E06C73D23BFD9DBF49269A4754B3489E X-C1DE0DAB: 0D63561A33F958A5A53EAC064C21090BD0C4A85BB86D57CBD9B8995AC290AF72D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75342909995EBBA6E4410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F8A2DF183797A6A81C6F26BA09337A789C63B2101D52352DABFB9F18D9EF49AD8A77A44F6D46AF821D7E09C32AA3244C41456350A64B8DFD9E9906F83F808679D08D48398F32B4A6FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojotfFaHYUgbBj/li1nLoz0g== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DE721343860E571E555F7A5BE6C64D8353841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH vshard 6/6] router: update master using a hint from storage X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" >   - After changes in previous patch I think it could be better to use "master_search_wakeup" instead of master_search_fiber:wakeup() Yes, I forgot to update this commit. Done now: ==================== diff --git a/test/router/master_discovery.result b/test/router/master_discovery.result index 8416c8f..7ebb67d 100644 --- a/test/router/master_discovery.result +++ b/test/router/master_discovery.result @@ -115,7 +115,7 @@ function check_no_master_for_replicaset(rs_id) if not master then \ return true \ end \ - vshard.router.static.master_search_fiber:wakeup() \ + vshard.router.master_search_wakeup() \ return false \ end | --- @@ -170,7 +170,7 @@ function check_master_discovery_block() if vshard.router.internal.errinj.ERRINJ_MASTER_SEARCH_DELAY == 'in' then \ return true \ end \ - vshard.router.static.master_search_fiber:wakeup() \ + vshard.router.master_search_wakeup() \ return false \ end | --- diff --git a/test/router/master_discovery.test.lua b/test/router/master_discovery.test.lua index 9a9e60d..6276dc9 100644 --- a/test/router/master_discovery.test.lua +++ b/test/router/master_discovery.test.lua @@ -73,7 +73,7 @@ function check_no_master_for_replicaset(rs_id) if not master then \ return true \ end \ - vshard.router.static.master_search_fiber:wakeup() \ + vshard.router.master_search_wakeup() \ return false \ end @@ -114,7 +114,7 @@ function check_master_discovery_block() if vshard.router.internal.errinj.ERRINJ_MASTER_SEARCH_DELAY == 'in' then \ return true \ end \ - vshard.router.static.master_search_fiber:wakeup() \ + vshard.router.master_search_wakeup() \ return false \ end ==================== >   - Should we document somehow `update_master` method for replicaset object? Or maybe it even shouldn't be a part of public API? Nope. It is a private method. If something is not documented on the site, it is private. I couldn't come up with a better scheme and yet not harm vshard's own code readability.