From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C5B092C270
	for <tarantool-patches@freelists.org>; Tue, 30 Oct 2018 15:41:50 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id sPBV1obZXcPS for <tarantool-patches@freelists.org>;
	Tue, 30 Oct 2018 15:41:50 -0400 (EDT)
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 872082BDDD
	for <tarantool-patches@freelists.org>; Tue, 30 Oct 2018 15:41:50 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v8 3/3] sql: remove psql_txn from
 Vdbe
References: <cover.1540832830.git.imeevma@gmail.com>
 <ce438a4888b055fa079996319d54dd57adc6eb97.1540832830.git.imeevma@gmail.com>
 <8AB5D4C3-8319-4F19-9A69-68A8819C2B72@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <c8c2d906-5132-ba74-b2ba-ee6d641f166f@tarantool.org>
Date: Tue, 30 Oct 2018 22:41:47 +0300
MIME-Version: 1.0
In-Reply-To: <8AB5D4C3-8319-4F19-9A69-68A8819C2B72@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>

Thanks for the review!

On 30/10/2018 17:30, n.pettik wrote:
> 
>> It makes no sense to store it here, and it has never
>> did.
> 
> Nit: this sentence is grammatically incorrect, I guess.

Sorry, just typo. I removed the second part of the
sentence. Look at the branch.

> 
>> SQL transaction specific things shall be taken
>> from global txn object, as any transaction specific
>> things.
> 
> Patch itself is OK, but I would either separate this patch from patch-set,
> or add "Follow up #xxxx” sign.

Done. I used 'follow up'.