From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BD891469710
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 21 Nov 2020 02:55:11 +0300 (MSK)
References: <20201112195121.191366-1-gorcunov@gmail.com>
 <20201112195121.191366-2-gorcunov@gmail.com>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <c836fa2b-b807-9fe1-e27e-3c537df9e8fe@tarantool.org>
Date: Sat, 21 Nov 2020 00:55:10 +0100
MIME-Version: 1.0
In-Reply-To: <20201112195121.191366-2-gorcunov@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 01/11] build: add more ignore paths
 for tags target
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>

Thanks for the patch!

On 12.11.2020 20:51, Cyrill Gorcunov wrote:
> Our .gitignore has been extended recently lets
> add more paths to skip when building the tags
> target.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>  CMakeLists.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index fa6818f8e..84f77dc2b 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -150,6 +150,12 @@ check_function_exists(getprogname HAVE_GETPROGNAME)
>  list(APPEND tagsExclude "--exclude=.git/*")
>  list(APPEND tagsExclude "--exclude=.pc/*")
>  list(APPEND tagsExclude "--exclude=patches/*")
> +list(APPEND tagsExclude "--exclude=.git-ignore/*")

What is this? I don't see it locally. So it is not generated, correct?
The same for 'coverity/', 'coverage/', '.idea' - I don't see then appearing
when I compile.

> +list(APPEND tagsExclude "--exclude=coverity/*")
> +list(APPEND tagsExclude "--exclude=coverage/*")
> +list(APPEND tagsExclude "--exclude=./build/*")
> +list(APPEND tagsExclude "--exclude=.idea/*")
> +list(APPEND tagsExclude "--exclude=src/module.h")
>  add_custom_target(tags COMMAND ${CTAGS} -R ${tagsExclude} -f tags
>      WORKING_DIRECTORY ${CMAKE_SOURCE_DIR})
>  add_custom_target(ctags DEPENDS tags)