From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 554FE24534 for ; Tue, 15 May 2018 14:42:31 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GSY_Ql_Gv6rO for ; Tue, 15 May 2018 14:42:31 -0400 (EDT) Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0E53D2452F for ; Tue, 15 May 2018 14:42:30 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 1/1] netbox: optimize body decoding References: <20180515183831.GA11426@atlas> From: Vladislav Shpilevoy Message-ID: Date: Tue, 15 May 2018 21:42:28 +0300 MIME-Version: 1.0 In-Reply-To: <20180515183831.GA11426@atlas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Konstantin Osipov Cc: tarantool-patches@freelists.org Hello. I fixed your remarks already. See the previous letter in this thread. > > Did you benchmark it? I'd expect a pretty hefty improvement, esp. > in case of large result sets. Care to run a test? One of our customers has benchmark. He opened the issue. But he uses netbox to execute SQL requests, so he can bench, when the patch reaches 2.0.