From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D16FF6EC56; Sat, 20 Mar 2021 01:17:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D16FF6EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616192275; bh=zkNpUi1jh+M++gepnuGjkXeYmbxLZmBlU6yV2Y+jVuk=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=DJIykjUqZYShfUFRUzAnnItU4y1ftKxwR3YJOnqOB9xo3ne1nBwpFNt8dDsqtYJ5t iAwkWOyLISwUOpznoSSjUVdPocuPj14j2tjhIxdfX3PjkYLUiHQBAbE0K/20/AXRe4 T6JfKFRAJIQn6G04Y7u1ueOyhZ6RpJcXbgrLltfo= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7E6406EC57 for ; Sat, 20 Mar 2021 01:17:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7E6406EC57 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lNNQu-0003uR-Pb; Sat, 20 Mar 2021 01:17:29 +0300 To: Cyrill Gorcunov Cc: tml , Mons Anderson References: <20210318184138.1077807-1-gorcunov@gmail.com> <20210318184138.1077807-3-gorcunov@gmail.com> <117fc87c-0317-db58-ea7a-df1325a6829d@tarantool.org> Message-ID: Date: Fri, 19 Mar 2021 23:17:27 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95D6E7CC48CB1F5F10D3016C09B407F8B1E2E766A3410B623182A05F538085040BFEC24C9A8FACB4AF4DEC9F62D5196EA0EE81E7F47A9DED46FD05718E03642E8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F2919D563845004AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063767500BC4578134A08638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C81A23F326053F827C525C5FD5804D2DCB3ECE5B09C514268A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE73AFA331E307B52169FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3ECBEDCEC3CCF9A28117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C2249F7FD1A3A8AE6177F089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7C78936B5CE05F1CBA43847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148F6B16E133A9586FB82623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2BBE337FB72E923155C0AF1600DCBC20BD52826C51A2876AB01D5E27AE65B8746 X-C1DE0DAB: 0D63561A33F958A5988D58A6047868FADF7C32B373DB48F0CD3A5EE4DFA281C2D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349FD10E01B3CDC9E27DE0BC44165C76D64A5D0327A96D0024FB751E730207B58E140FE67E92B5B55E1D7E09C32AA3244CF11B0E0F12449F826F9EE92F76F8765A5A1673A01BA68E40FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojyKyJYJ15DtIFFrDDYJ97iA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822FB12D278F2994F694DC6468C4D65A0AD3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 2/2] test: add a test for wal_cleanup_delay option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 19.03.2021 13:14, Cyrill Gorcunov via Tarantool-patches wrote: > On Fri, Mar 19, 2021 at 12:04:11AM +0100, Vladislav Shpilevoy wrote: >>> + >>> +function func_xlog_snap(space, value) >> >> 1. This fails luacheck (which I don't like having in the tests, >> but still we must keep it green): >> >> Checking test/replication/gh-5806-master.lua 1 warning >> >> test/replication/gh-5806-master.lua:5:10: (W111) setting non-standard global variable func_xlog_snap >> >> Checking test/replication/gh-5806-slave.lua 1 warning >> >> test/replication/gh-5806-slave.lua:5:10: (W111) setting non-standard global variable func_xlog_snap > > Thanks, Vlad! Actually I don't understand what this warning means. Should I make > these functions local or what? Yeah, we can't declare global variables/functions. When you want a function, you must either assign it to an index in _G, or have it in a separate module and add it via 'require()' in the test's body. But it should not matter now if you delete this function. >> 4. Why do you do rw requests both on the replica and master? > > To intermix data so that lsns would be different Why should they be different (this all better be in the comments)? >> And why do you need 2 spaces? > > This allows to write xlog data specifically on replica and > only in this case I managed to reach XlogGapError (otherwise > the replica reported that it is too old and restarted rejoin > procedure). Aha, so it can't rejoin automatically, because this would lead to data loss. I see now. Please, document it in the test.