From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 56BC16EC6F; Fri, 26 Feb 2021 03:57:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 56BC16EC6F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614301050; bh=rcV4q4S8Ae0qwyYh9Ebcs6OWApmTA0uYDaEj/eIHkfg=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=NJLRukD3Rc+VnwE34cEfv6jx4gjkcTYehYXtb+HZ8itULlO7kCbAWvkk4Cl37LkNy bXYc/84at6E5txamQt/swr6FzpSmZ408LmDiL6Cu5Xi4AeY7GtQl0ohkx/PbMfwo3D XwluQT/B8wKiKShxxI9ujmHxXWAYpEm+6jB6Ysz8= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D76196EC6F for ; Fri, 26 Feb 2021 03:57:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D76196EC6F Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lFRRf-0004YT-AE; Fri, 26 Feb 2021 03:57:27 +0300 To: Konstantin Osipov , Serge Petrenko , gorcunov@gmail.com, tarantool-patches@dev.tarantool.org References: <20210224193549.70017-1-sergepetrenko@tarantool.org> <20210225130514.GB18388@starling> Message-ID: Date: Fri, 26 Feb 2021 01:57:26 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210225130514.GB18388@starling> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD975C3EC174F56692243410BA6471F01664CBE9F2A03BCE963182A05F538085040B23E5AE30C4A9876BDB48CA2BE52C7A362B160D3F2C1D97E29C543F64824E418 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AEA4A6B3AFC9B957C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE775092E6AE21AB47A8F08D7030A58E5ADC58D69EE07B14084C6CDE5D1141D2B1CE70C468FE0D51C532431691399FB07B0F497D1353AF752E19FA2833FD35BB23D9E625A9149C048EE33AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B5FC25ED3FCEC3375A471835C12D1D977C4224003CC836476EC64975D915A344093EC92FD9297F6718AA50765F7900637C970FD8DF19C51D2A7F4EDE966BC389F395957E7521B51C24C7702A67D5C33162DBA43225CD8A89F9FFED5BD9FB4175557739F23D657EF2BB5C8C57E37DE458B4C7702A67D5C3316FA3894348FB808DB985633C00BAEBE4F574AF45C6390F7469DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5514BC255EDAE9543EBC8BF54E6EBA6D0C067752A9CD45E31D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75968C9853642EB7C3410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34682FD2D2951524C56CFEC8F9061888E1EC94398C82A027271346E564A46FC688D43A5B2FDBD3E8F01D7E09C32AA3244C9185435BF560646FAE0C07B25D49B877F522A1CF68F4BE05927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj8mqzvzJVEn1C4MgMkKhdEQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638223E38E246456C95D2EF4B9C6B47E4A4743841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3] wal: introduce limits on simultaneous writes X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" > I'd also question the place where you decided to put this gate. > The source of the issue is async requests, not WAL, which worked > fine in absence of async requests. So it's async requests that > should be gated, not WAL. In the commit message it is clearly stated why it is in the journal's code, not just in the applier: The feature is ready for `box.commit{is_async=true}`. Once it's implemented, it should check whether the queue is full and let the user decide what to do next. Either wait or roll the tx back. Async transactions will be exposed to 'userspace' to be able to reduce latency for network requests ending with a transaction. They won't have to wait for WAL write to end. > Otherwise your overflow will just spill out someplace else. On the contrary. Your proposal to do it in the applier would lead to queue overflow in some other place - in userspace. When the queue is for the entire WAL, it won't overflow.