From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6217E469710 for ; Fri, 5 Jun 2020 22:14:55 +0300 (MSK) References: <20200605185544.54436-1-gorcunov@gmail.com> From: Oleg Babin Message-ID: Date: Fri, 5 Jun 2020 22:14:51 +0300 MIME-Version: 1.0 In-Reply-To: <20200605185544.54436-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v9 0/2] lua/log: add an ability to setup logger without box.cfg{} List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov , tml Hi! Thanks for your patchset. I think this series should be pushed - LGTM. However I have several comments: - Don't forget to file an issue to rework approarch to module configuratoin and remove dead code (I suppose that functions private.cfg_set_log_level and private.cfg_set_log_format will be unused after that); - It would be nice to add tests from your previous series where you test possibility to pass string as log level. On 05/06/2020 21:55, Cyrill Gorcunov wrote: > In the series we add an ability to configure logger early without > calling box.cfg{}. The syntax is the same as in box.cfg{} call. > > There was an idea to implement something similar via triggers but > I think this will require a way more efforts and code redesign, > so at first lets stick to simplier solution. > > I'm pretty sure we will be able to simplify and beautify code more later. > > v9: > - complete reworking of the whole series > > branch gorcunov/gh-689-logger-9 > issue https://github.com/tarantool/tarantool/issues/689 > > Cyrill Gorcunov (2): > lua/log: add ability to configure logging early > test: app-tap/logger -- test new modes > > src/box/lua/load_cfg.lua | 65 ++++-- > src/lua/log.lua | 404 +++++++++++++++++++++++++++++++++-- > test/app-tap/logger.test.lua | 83 ++++++- > test/box/reconfigure.result | 2 +- > 4 files changed, 512 insertions(+), 42 deletions(-) >