From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 76F7E24716
	for <tarantool-patches@freelists.org>; Tue, 22 Jan 2019 14:59:07 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 59YVALKJ7VoV for <tarantool-patches@freelists.org>;
	Tue, 22 Jan 2019 14:59:07 -0500 (EST)
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 93BA524656
	for <tarantool-patches@freelists.org>; Tue, 22 Jan 2019 14:59:06 -0500 (EST)
Subject: [tarantool-patches] Re: [PATCH v8 1/6] lua: remove exceptions from
 function luaL_tofield()
References: <cover.1547902954.git.imeevma@gmail.com>
 <f3d5e7ec4d7b75f81a022ce196fc2a8fdd4f5b98.1547902954.git.imeevma@gmail.com>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <c72792bf-f5bb-e7fe-8277-0498a1284e05@tarantool.org>
Date: Tue, 22 Jan 2019 22:58:52 +0300
MIME-Version: 1.0
In-Reply-To: <f3d5e7ec4d7b75f81a022ce196fc2a8fdd4f5b98.1547902954.git.imeevma@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, imeevma@tarantool.org

Thanks for the fixes!

> Diff between versions:
> 
> commit 07bcff72336fe861fd51d895fe088662a9d09fe4
> Author: Mergen Imeev <imeevma@gmail.com>
> Date:   Thu Jan 17 15:00:27 2019 +0300
> 
>      Temporary: Review fixes

Please, do not merge diff of all comments into a single one. It
is hardly possible to restore which part of this diff corresponds
to which comment. Inline diff, fixing one comment, under this comment,
like Nikita does.

Also, I see that the branch still stores the old patchset. Please,
push it. Until that I can not review it.

> commit 3080ab1d7d2e8d8716ac91fc71150db7cde4ffe4
> Author: Mergen Imeev <imeevma@gmail.com>
> Date:   Fri Jan 11 21:16:12 2019 +0300
> 
>      lua: remove exceptions from function luaL_tofield()
>      
>      Before this commit, the luaL_tofield() function threw a Lua
>      exception when an error occurred. This behavior has been changed
>      in this commit, now it sets diag_set() and returns -1 in case of
>      an error.
>      
>      Needed for ...3505

Please, use #, not ... .