Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Sergey Nikiforov <void@tarantool.org>,
	tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 2/2] base64: improve decoder performance
Date: Tue, 22 Dec 2020 16:05:33 +0100	[thread overview]
Message-ID: <c6e7aa32-303c-e885-5e0c-0c48da715206@tarantool.org> (raw)
In-Reply-To: <f4e630f7f591fba4001a9edd35ecf6c0b490811a.1608633086.git.void@tarantool.org>

Thanks for the patch!

> diff --git a/test/unit/base64.c b/test/unit/base64.c
> index ada497adf..76db7d782 100644
> --- a/test/unit/base64.c
> +++ b/test/unit/base64.c
> @@ -34,6 +34,11 @@ base64_test(const char *str, int options, const char *no_symbols,
>  	free(base64_buf);
>  	free(strbuf);
>  
> +	const char *in = "sIIpHw==";
> +	int in_len = strlen(in);
> +	rc = base64_decode(in, in_len, NULL, 0);
> +	is(rc, 0, "no space in out buffer");

From the .result file it is clear this test is done multiple
times. And it does not depend on base64_test() arguments. So why
do you run exactly the same test again and again? Maybe move it
to a separate test function which is run only once?

> +
>  	check_plan();
>  }
>  
> diff --git a/test/unit/base64.result b/test/unit/base64.result
> index cd1f2b3f6..d606772ea 100644
> --- a/test/unit/base64.result
> +++ b/test/unit/base64.result
> @@ -1,178 +1,206 @@
>  1..28
>  	*** main ***
> -    1..3
> +    1..4
>      ok 1 - length
>      ok 2 - decode length ok
>      ok 3 - encode/decode
> +    ok 4 - no space in out buffer
>  ok 1 - subtests
> -    1..6
> +    1..7
>      ok 1 - length
>      ok 2 - no \n symbols
>      ok 3 - no + symbols
>      ok 4 - no = symbols
>      ok 5 - decode length ok
>      ok 6 - encode/decode
> +    ok 7 - no space in out buffer
>  ok 2 - subtests
> -    1..4
> +    1..5
>      ok 1 - length
>      ok 2 - no = symbols
>      ok 3 - decode length ok
>      ok 4 - encode/decode
> +    ok 5 - no space in out buffer
>  ok 3 - subtests
> -    1..4
> +    1..5
>      ok 1 - length
>      ok 2 - no \n symbols
>      ok 3 - decode length ok
>      ok 4 - encode/decode
> +    ok 5 - no space in out buffer
>  ok 4 - subtests
> -    1..3
> +    1..4
>      ok 1 - length
>      ok 2 - decode length ok
>      ok 3 - encode/decode
> +    ok 4 - no space in out buffer
>  ok 5 - subtests
> -    1..6
> +    1..7
>      ok 1 - length
>      ok 2 - no \n symbols
>      ok 3 - no + symbols
>      ok 4 - no = symbols
>      ok 5 - decode length ok
>      ok 6 - encode/decode
> +    ok 7 - no space in out buffer
>  ok 6 - subtests
> -    1..4
> +    1..5
>      ok 1 - length
>      ok 2 - no = symbols
>      ok 3 - decode length ok
>      ok 4 - encode/decode
> +    ok 5 - no space in out buffer
>  ok 7 - subtests
> -    1..4
> +    1..5
>      ok 1 - length
>      ok 2 - no \n symbols
>      ok 3 - decode length ok
>      ok 4 - encode/decode
> +    ok 5 - no space in out buffer
>  ok 8 - subtests
> -    1..3
> +    1..4
>      ok 1 - length
>      ok 2 - decode length ok
>      ok 3 - encode/decode
> +    ok 4 - no space in out buffer
>  ok 9 - subtests
> -    1..6
> +    1..7
>      ok 1 - length
>      ok 2 - no \n symbols
>      ok 3 - no + symbols
>      ok 4 - no = symbols
>      ok 5 - decode length ok
>      ok 6 - encode/decode
> +    ok 7 - no space in out buffer
>  ok 10 - subtests
> -    1..4
> +    1..5
>      ok 1 - length
>      ok 2 - no = symbols
>      ok 3 - decode length ok
>      ok 4 - encode/decode
> +    ok 5 - no space in out buffer
>  ok 11 - subtests
> -    1..4
> +    1..5
>      ok 1 - length
>      ok 2 - no \n symbols
>      ok 3 - decode length ok
>      ok 4 - encode/decode
> +    ok 5 - no space in out buffer
>  ok 12 - subtests
> -    1..3
> +    1..4
>      ok 1 - length
>      ok 2 - decode length ok
>      ok 3 - encode/decode
> +    ok 4 - no space in out buffer
>  ok 13 - subtests
> -    1..6
> +    1..7
>      ok 1 - length
>      ok 2 - no \n symbols
>      ok 3 - no + symbols
>      ok 4 - no = symbols
>      ok 5 - decode length ok
>      ok 6 - encode/decode
> +    ok 7 - no space in out buffer
>  ok 14 - subtests
> -    1..4
> +    1..5
>      ok 1 - length
>      ok 2 - no = symbols
>      ok 3 - decode length ok
>      ok 4 - encode/decode
> +    ok 5 - no space in out buffer
>  ok 15 - subtests
> -    1..4
> +    1..5
>      ok 1 - length
>      ok 2 - no \n symbols
>      ok 3 - decode length ok
>      ok 4 - encode/decode
> +    ok 5 - no space in out buffer
>  ok 16 - subtests
> -    1..3
> +    1..4
>      ok 1 - length
>      ok 2 - decode length ok
>      ok 3 - encode/decode
> +    ok 4 - no space in out buffer
>  ok 17 - subtests
> -    1..6
> +    1..7
>      ok 1 - length
>      ok 2 - no \n symbols
>      ok 3 - no + symbols
>      ok 4 - no = symbols
>      ok 5 - decode length ok
>      ok 6 - encode/decode
> +    ok 7 - no space in out buffer
>  ok 18 - subtests
> -    1..4
> +    1..5
>      ok 1 - length
>      ok 2 - no = symbols
>      ok 3 - decode length ok
>      ok 4 - encode/decode
> +    ok 5 - no space in out buffer
>  ok 19 - subtests
> -    1..4
> +    1..5
>      ok 1 - length
>      ok 2 - no \n symbols
>      ok 3 - decode length ok
>      ok 4 - encode/decode
> +    ok 5 - no space in out buffer
>  ok 20 - subtests
> -    1..3
> +    1..4
>      ok 1 - length
>      ok 2 - decode length ok
>      ok 3 - encode/decode
> +    ok 4 - no space in out buffer
>  ok 21 - subtests
> -    1..6
> +    1..7
>      ok 1 - length
>      ok 2 - no \n symbols
>      ok 3 - no + symbols
>      ok 4 - no = symbols
>      ok 5 - decode length ok
>      ok 6 - encode/decode
> +    ok 7 - no space in out buffer
>  ok 22 - subtests
> -    1..4
> +    1..5
>      ok 1 - length
>      ok 2 - no = symbols
>      ok 3 - decode length ok
>      ok 4 - encode/decode
> +    ok 5 - no space in out buffer
>  ok 23 - subtests
> -    1..4
> +    1..5
>      ok 1 - length
>      ok 2 - no \n symbols
>      ok 3 - decode length ok
>      ok 4 - encode/decode
> +    ok 5 - no space in out buffer
>  ok 24 - subtests
> -    1..3
> +    1..4
>      ok 1 - length
>      ok 2 - decode length ok
>      ok 3 - encode/decode
> +    ok 4 - no space in out buffer
>  ok 25 - subtests
> -    1..6
> +    1..7
>      ok 1 - length
>      ok 2 - no \n symbols
>      ok 3 - no + symbols
>      ok 4 - no = symbols
>      ok 5 - decode length ok
>      ok 6 - encode/decode
> +    ok 7 - no space in out buffer
>  ok 26 - subtests
> -    1..4
> +    1..5
>      ok 1 - length
>      ok 2 - no = symbols
>      ok 3 - decode length ok
>      ok 4 - encode/decode
> +    ok 5 - no space in out buffer
>  ok 27 - subtests
> -    1..4
> +    1..5
>      ok 1 - length
>      ok 2 - no \n symbols
>      ok 3 - decode length ok
>      ok 4 - encode/decode
> +    ok 5 - no space in out buffer
>  ok 28 - subtests

  reply	other threads:[~2020-12-22 15:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-22 10:41 [Tarantool-patches] [PATCH v3 0/2] base64: fix decoder, improve its performance Sergey Nikiforov
2020-12-22 10:41 ` [Tarantool-patches] [PATCH v3 1/2] base64: fix decoder output buffer overrun (reads) Sergey Nikiforov
2020-12-24 12:28   ` Leonid Vasiliev
2020-12-22 10:41 ` [Tarantool-patches] [PATCH v3 2/2] base64: improve decoder performance Sergey Nikiforov
2020-12-22 15:05   ` Vladislav Shpilevoy [this message]
2020-12-22 16:16     ` Sergey Nikiforov
2020-12-22 16:40       ` Vladislav Shpilevoy
2020-12-24 14:08   ` Leonid Vasiliev
2020-12-25 10:39     ` Sergey Nikiforov
2020-12-25 13:10       ` Leonid Vasiliev
2020-12-24 14:14 Leonid Vasiliev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6e7aa32-303c-e885-5e0c-0c48da715206@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=void@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v3 2/2] base64: improve decoder performance' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox