From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BF57F41C5DC
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  2 Jul 2020 11:25:28 +0300 (MSK)
References: <cover.1593472477.git.v.shpilevoy@tarantool.org>
 <889461570dc63dba919b19b620a481ead13c2d3a.1593472477.git.v.shpilevoy@tarantool.org>
 <ffabb492-fd7f-702d-1d16-d65628a5e4f4@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <c6d4d955-3b18-b858-0a58-94a61125fda6@tarantool.org>
Date: Thu, 2 Jul 2020 11:25:27 +0300
MIME-Version: 1.0
In-Reply-To: <ffabb492-fd7f-702d-1d16-d65628a5e4f4@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH v2 01/19] replication: introduce
 space.is_sync option
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org


01.07.2020 02:00, Vladislav Shpilevoy пишет:
> On 30/06/2020 01:15, Vladislav Shpilevoy wrote:
>> Synchronous space makes every transaction, affecting its data,
>> wait until it is replicated on a quorum of replicas before it is
>> committed.
>>
>> Part of #4844
>> Part of #5073
>> ---
>>   src/box/alter.cc                              |  5 ++
>>   src/box/lua/net_box.lua                       |  2 +
>>   src/box/lua/schema.lua                        |  3 +
>>   src/box/lua/space.cc                          |  5 ++
>>   src/box/space_def.c                           |  2 +
>>   src/box/space_def.h                           |  6 ++
>>   .../sync_replication_sanity.result            | 71 +++++++++++++++++++
>>   .../sync_replication_sanity.test.lua          | 29 ++++++++
> Renamed to qsync_basic.test.lua. The old name was too long, and wasn't
> about just sanity checks, which are usually extremely simple.

LGTM, thanks!

-- 
Serge Petrenko