From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C42052A601 for ; Tue, 2 Apr 2019 04:34:11 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wL83H407lrPt for ; Tue, 2 Apr 2019 04:34:11 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7ABD82A5F3 for ; Tue, 2 Apr 2019 04:34:11 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v10 3/4] sql: create box.execute() References: <4b3ca18628a2ed3d0cbf70c4e0d0e6e182fa33ad.1554148476.git.v.shpilevoy@tarantool.org> <20190402082110.GM25072@chai> From: Imeev Mergen Message-ID: Date: Tue, 2 Apr 2019 11:34:08 +0300 MIME-Version: 1.0 In-Reply-To: <20190402082110.GM25072@chai> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Konstantin Osipov , tarantool-patches@freelists.org Cc: kyukhin@tarantool.org, Mergen Imeev On 4/2/19 11:21 AM, Konstantin Osipov wrote: > * Vladislav Shpilevoy [19/04/01 23:03]: >> + luaL_pushuint64(L, db->nChange); >> + lua_setfield(L, -2, "rowcount"); > Another small nit is about this name. We write > IPROTO_SQL_ROW_COUNT as a key name, but rowcount (note no > underscore) in Lua. I would either use a consistent naming (either > with or without underscore), or, better yet, find a name which > doesn't provoke confusion. > Considering we use autoincrement_ids (notice absence of space > after auto), I'd call the member row_count. > > Do you mind if I do this as follow up separate patch? Also I plan to use sql_info_key_strs in netbox_decode_sql_info() and port_sql_dump_lua() for this.