From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7A3FD469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 24 Nov 2020 00:58:41 +0300 (MSK)
References: <cover.1605685304.git.babinoleg@mail.ru>
 <f2b6f003939881319d086af9738190b869693eb9.1605685304.git.babinoleg@mail.ru>
 <caa0f815-c076-ab7a-9419-d41c00638afa@tarantool.org>
 <52439555-a382-189e-941a-22aa4b0e2683@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <c6ba37d8-3189-48c6-5f88-eb5a9c4ab80f@tarantool.org>
Date: Mon, 23 Nov 2020 22:58:38 +0100
MIME-Version: 1.0
In-Reply-To: <52439555-a382-189e-941a-22aa4b0e2683@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH v2 1/2] uuid: support comparison of
 uuid values in Lua
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>, lvasiliev@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the fixes!

> diff --git a/src/lua/uuid.lua b/src/lua/uuid.lua
> index 08991cfeb..275f4e5c5 100644
> --- a/src/lua/uuid.lua
> +++ b/src/lua/uuid.lua
> @@ -93,13 +93,20 @@ local uuid_isnil = function(uu)
>      return builtin.tt_uuid_is_nil(uu)
>  end
> 
> +local check_uuid = function(value, index)
> +    if is_uuid(value) then
> +        return value
> +    end
> +
> +    local err_fmt = 'incorrect value to compare with uuid as %d argument'
> +    error(err_fmt:format(index), 4)
> +end
> +
>  local uuid_eq = function(lhs, rhs)
>      if not is_uuid(rhs) then
>          return false
>      end
> -    if not is_uuid(lhs) then
> -        return error('Usage: uuid == var')
> -    end
> +    lhs = check_uuid(lhs, 1)

Check_uuid() here uses incorrect error index. check_uuid()
raises error(..., 4). So check_uuid() itself is level 1.
uuid_eq() is level 2. And the calling code is level 3. You
will raise one level beyond the caller code.

For uuid_lt and uuid_le it works, because check_uuid() is
level 1, uuid_cmp() is level 2, uuid_lt/le() is level 3, and
the calling code is level 4.

But I can't give you a test, since I have no idea how to provide
lhs with non-uuid type. Igor said we can give metatable of uuid to
some non-uuid value, but I failed to assign uuid metatable to
anything else.

After you fix this (but I don't insist on adding a test, because
I don't know how), I suggest you to get a second review from Igor.