From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 312084429E1
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 20 Jun 2020 02:15:10 +0300 (MSK)
References: <cover.1591259297.git.sergeyb@tarantool.org>
 <20200604084340.GA47445@pony.bronevichok.ru>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <c62efbf4-da2e-58a6-9064-9f23fdb6e88c@tarantool.org>
Date: Sat, 20 Jun 2020 01:15:07 +0200
MIME-Version: 1.0
In-Reply-To: <20200604084340.GA47445@pony.bronevichok.ru>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 0/6] Add static analysis of Lua code
 in src/ and extra/ with luacheck
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Bronnikov <sergeyb@tarantool.org>, tarantool-patches@dev.tarantool.org, imun@tarantool.org
Cc: alexander.turenko@tarantool.org

Hi! Thanks for the fixes!

The check fails in gitlab:
https://gitlab.com/tarantool/tarantool/-/jobs/600867104

Also it fails locally:

	Checking src/lua/log.lua                          2 warnings

	    src/lua/log.lua:321:33: (W212) unused argument update_box_cfg
	    src/lua/log.lua:441:25: (W212) unused argument oldcfg