Tarantool development patches archive
 help / color / mirror / Atom feed
From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tarantool-patches@dev.tarantool.org, skaplun@tarantool.org,
	sergos@tarantool.org
Subject: [Tarantool-patches] [PATCH luajit 3/5] Disable unreliable assertion for external frame unwinding.
Date: Wed, 15 Feb 2023 01:30:25 +0300	[thread overview]
Message-ID: <c585f526a2e193ec65720af08b7ef0816d4c7412.1676413474.git.m.kokryashkin@tarantool.org> (raw)
In-Reply-To: <cover.1676413473.git.m.kokryashkin@tarantool.org>

From: Mike Pall <mike>

Broken on Fedora/ARM64. Reported by Yichun Zhang.

(cherry-picked from commit e957737650e060d5bf1c2909b741cc3dffe073ac)

This patch disables the assertion that failed because of
incorrectly constructed unwind information.
That debug info generation was fixed in the scope
of tarantool/tarantool#6096. This patch is backported
only for consistency.

Maxim Kokryashkin:
* added the description for the problem

Part of tarantool/tarantool#7745
Relates to tarantool/tarantool#6096
---
 src/lj_err.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/lj_err.c b/src/lj_err.c
index c7fd9e65..f6200233 100644
--- a/src/lj_err.c
+++ b/src/lj_err.c
@@ -488,7 +488,9 @@ void lj_err_verify(void)
   ** lj_assertX(_Unwind_Find_FDE((void *)_Unwind_RaiseException, &ehb), "broken build: external frame unwinding enabled, but system libraries have no unwind tables");
   */
   lua_assert(_Unwind_Find_FDE((void *)lj_err_throw, &ehb));
+  /* Check disabled, because of broken Fedora/ARM64. See #722.
   lua_assert(_Unwind_Find_FDE((void *)_Unwind_RaiseException, &ehb));
+  */
 }
 #endif
 
-- 
2.39.0


  parent reply	other threads:[~2023-02-14 22:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 22:30 [Tarantool-patches] [PATCH luajit 0/5] jit: add exception unwinding Maxim Kokryashkin via Tarantool-patches
2023-02-14 22:30 ` [Tarantool-patches] [PATCH luajit 1/5] test: disable `lj-603-snap-restore` test Maxim Kokryashkin via Tarantool-patches
2023-02-14 22:30 ` [Tarantool-patches] [PATCH luajit 2/5] Handle on-trace OOM errors from helper functions Maxim Kokryashkin via Tarantool-patches
2023-02-16 11:36   ` Sergey Kaplun via Tarantool-patches
2023-02-14 22:30 ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-02-16  6:58   ` [Tarantool-patches] [PATCH luajit 3/5] Disable unreliable assertion for external frame unwinding Sergey Kaplun via Tarantool-patches
2023-02-14 22:30 ` [Tarantool-patches] [PATCH luajit 4/5] OSX: " Maxim Kokryashkin via Tarantool-patches
2023-02-16  6:50   ` Sergey Kaplun via Tarantool-patches
2023-02-14 22:30 ` [Tarantool-patches] [PATCH luajit 5/5] Fix IR_RENAME snapshot number. Follow-up fix for a32aeadc Maxim Kokryashkin via Tarantool-patches
2023-02-16  7:03   ` Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c585f526a2e193ec65720af08b7ef0816d4c7412.1676413474.git.m.kokryashkin@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=max.kokryashkin@gmail.com \
    --cc=sergos@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 3/5] Disable unreliable assertion for external frame unwinding.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox