From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D9F9A45C304 for ; Wed, 9 Dec 2020 23:58:19 +0300 (MSK) References: <182d1ca7f245c252c5d1b70416c5b25564f7bee0.1607326642.git.sergeyb@tarantool.org> From: Leonid Vasiliev Message-ID: Date: Wed, 9 Dec 2020 23:57:23 +0300 MIME-Version: 1.0 In-Reply-To: <182d1ca7f245c252c5d1b70416c5b25564f7bee0.1607326642.git.sergeyb@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 4/6] add initial flake8 config List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org Cc: alexander.turenko@tarantool.org Hi! Thank you for the patch. Add subsystem to commit title. This seems like an overkill to me, because, if I understand correctly, we didn't plan to write new tests on python for tarantool. I propose to discuss this with Alexander after the standup. On 07.12.2020 10:46, sergeyb@tarantool.org wrote: > From: Sergey Bronnikov > > flake8 configuration file supress warnings, that can be fixed later. > Supressed warnings can be splitted for three categories and for each of them > separate issue exists: > > - Fix warnings Exx: #5599 > - Fix warnings Fxx: #5598 > - Fix warnings Wxx: #5597 > --- > .flake8 | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 .flake8 > > diff --git a/.flake8 b/.flake8 > new file mode 100644 > index 000000000..249970226 > --- /dev/null > +++ b/.flake8 > @@ -0,0 +1,66 @@ > +[flake8] > +inline-quotes = " > +statistics = True > +select = Q0 > +exclude = test/test-run.py > +ignore = > + # E111: indentation is not a multiple of four > + E111, > + # E123: closing bracket does not match indentation of opening bracket's line > + E123, > + # E126: continuation line over-indented for hanging indent > + E126, > + # E128: continuation line under-indented for visual indent > + E128, > + # E201: whitespace after '(' > + E201, > + # E202: whitespace before ')' > + E202, > + # E203: whitespace before ':' > + E203, > + # E225: missing whitespace around operator > + E225, > + # E226: missing whitespace around arithmetic operator > + E226, > + # E231: missing whitespace after ',', ';' or ':' > + E231, > + # E241: multiple spaces after ',' > + E241, > + # E251: unexpected spaces around keyword / parameter equals > + E251, > + # E261: at least two spaces before inline comment > + E261, > + # E265: block comment should start with '#' > + E265, > + # E266: too many leading '#' for block comment > + E266, > + # E302: expected 2 blank lines, found 0 > + E302, > + # E305: expected 2 blank lines after end of function or class > + E305, > + # E402: module level import not at top of file > + E402, > + # E501: line too long (82 > 79 characters) > + E501, > + # E502: the backslash is redundant between brackets > + E502, > + # E703: statement ends with a semicolon > + E703, > + # E722: do not use bare except, specify exception instead > + E722, > + # F401: module imported but unused > + F401, > + # F403: 'from module import *' used; unable to detect undefined names > + F403, > + # F405: name may be undefined, or defined from star imports: module > + F405, > + # F821: undefined name name > + F821, > + # F841: local variable name is assigned to but never used > + F841, > + # W291: trailing whitespace > + W291, > + # W391: blank line at end of file > + W391, > + # W605: invalid escape sequence 'x' > + W605 >