From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 881EF6EC5D; Thu, 8 Apr 2021 16:43:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 881EF6EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617889437; bh=BCh7zVvQV3r4idiTLyfC4L5mh9DD97SdTA4HbIt8cwo=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xAWqyY1sToJDw7KRqjd/y+JtMYNKtR2pNKZ5AAyx2PAhJ2CKfdur/Wox/CNUoWak1 dF3rob+k5A8acNTEFlskgG3zQJHsBbjsNi87dfOoA/ar7sDLZ7A7q0GiogCtMBAC+l o6AFl/IVNWVsgvuKbLdcU4Hge4TK1myjUHPDEg0E= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1986D6EC63 for ; Thu, 8 Apr 2021 16:41:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1986D6EC63 Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1lUUuk-0003PF-GX; Thu, 08 Apr 2021 16:41:42 +0300 To: Vladislav Shpilevoy , alexander.turenko@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <53f906760f240ea0f381fd693000139e8d5e5c8c.1617375300.git.sergepetrenko@tarantool.org> <226e5b15-049b-38ec-c03a-3af26989fe55@tarantool.org> Message-ID: Date: Thu, 8 Apr 2021 16:41:41 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <226e5b15-049b-38ec-c03a-3af26989fe55@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD912A3E3D5D4B49FC1FED631623C873017929456591B90F20100894C459B0CD1B918445241EF85FC9623E8E34DF9E8603538DE5FFF3BE30100D2FD38C2D22A140C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE797F4D2EDC29AFAF7EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637782358EF9635990EEA1F7E6F0F101C67CDEEF6D7F21E0D1D9295C2E9FA3191EE1B59CA4C82EFA658FD0475A7FFAA747FFA8C10952F8F0DE1F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249A70DDFFB3186CBC5CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C045A75973B56231AD8941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C39472471D10B198B935872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A584DB1DA1EF92FBB71AF2F61EBF3D5DC4F6507D71D44BBCB0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343D1F112031EF3D6238B254B778251D6C2B1440ED839FEF69B4FF8319B99FA894EBD42BA9C25C42D01D7E09C32AA3244C553624D7A1A34412FB4474843A030E7230452B15D76AEC14FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioju+jaMfvANXrXcWUImJgJCA== X-Mailru-Sender: 3B9A0136629DC9125D61937A2360A4465E4806B976005D2AB14BCF9DC058A71A6B5DA72358B5CC81424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/4] feedback_daemon: send feedback on server start X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 05.04.2021 19:11, Vladislav Shpilevoy пишет: > > On 05.04.2021 16:05, Serge Petrenko wrote: >> >> 05.04.2021 16:18, Vladislav Shpilevoy пишет: >>> Hi! Thanks for the patch! >>> >>> On 02.04.2021 16:58, Serge Petrenko wrote: >>>> Send the first report as soon as instance's initial configuration >>>> finishes. >>>> >>>> Closes #5750 >>>> --- >>>> diff --git a/src/box/lua/feedback_daemon.lua b/src/box/lua/feedback_daemon.lua >>>> index d00eedf39..2ce768642 100644 >>>> --- a/src/box/lua/feedback_daemon.lua >>>> +++ b/src/box/lua/feedback_daemon.lua >>>> @@ -345,7 +345,7 @@ local function guard_loop(self) >>>>       while true do >>>>             if get_fiber_id(self.fiber) == 0 then >>>> -            self.fiber = fiber.create(feedback_loop, self) >>>> +            self.fiber = fiber.new(feedback_loop, self) >>> Why? >> With fiber.create() feedback daemon proceeds to sending the "initial report" even before >> lua's box.cfg() exits. This shouldn't break anything, as far as I understand, but >> `tarantoolctl.test.lua` failed on my machine without this change. > But box.cfg yields. Does it mean it still ends before box.cfg ends too, > if box.cfg yields? Probably, yes. I reverted this change after all. It didn't help much, and looks like the problem was deeper than I thought. It wasn't about box.cfg{} exiting too early. The problem is with some curl initializations on the first ever request, which happens to be the feedback daemon report. I worked this around by sleeping for 10 seconds before proceeding to the dispatch. Fixes tests both locally and in CI. Please find v2 in your mailbox. -- Serge Petrenko