From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2CBBA580C9C; Tue, 24 Sep 2024 20:41:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2CBBA580C9C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1727199697; bh=uStULDhM+5JxvBA0LC/rD7EQKfaRKYLN2kww7bRgRts=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=r5V54OBNbo88m7LjtMbWl5cYFXCMoQqr+pjWkgCaYPDM6HDwWk7OZ+HwX8rVT2rRd WhpvCTfOLFtsUZElExxn7GEFu/P6HLCx+zpnt6ZzHwdgJ3MLlqFnClHS6CZePFWGg7 fGS47edKlSOkA28SsO3o5SK4RE6cZRrL3yX2uUEU= Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [95.163.41.96]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6FB0D580C9C for ; Tue, 24 Sep 2024 20:41:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6FB0D580C9C Received: by smtp58.i.mail.ru with esmtpa (envelope-from ) id 1st9XZ-0000000BR7s-46zN; Tue, 24 Sep 2024 20:41:34 +0300 Content-Type: multipart/alternative; boundary="------------dQMu8Ld3RennQGHSUknUj9ne" Message-ID: Date: Tue, 24 Sep 2024 20:41:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <3078cc813a6789de05ceb162093f40f5f48de455.1727172936.git.skaplun@tarantool.org> <1d07cc3d-10b4-4ea4-8d71-421b4f6e0c95@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD941CBEC3D08EBAA0971DA4E6AFD7BE56DAC55D89031953764182A05F5380850404C228DA9ACA6FE27FA55819986B825F133594132A326AF8B53F64F6198FCEDBADAF646C1BB526D278E573506CDC45F9B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BF6702EC5472AA0FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637838376990962B7D5EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F36EA6E581CC0ED0E2FDF622582B84E840A45F2FDB7FAEF4938A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE740E9CF2C1C1CEBBA7B076A6E789B0E97A8DF7F3B2552694AD5FFEEA1DED7F25D49FD398EE364050F140C956E756FBB7AC0837EA9F3D19764C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F790063752464DD08821749FEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A580AB99770875D56F5002B1117B3ED69652D1F74E0C9B538E69995D676B7B4CBE823CB91A9FED034534781492E4B8EEAD2B25D9E4C92BC8ACBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C53D1911AD7E41991ABF2DE8BCC037833BC251FC336C516D494983AF2879EB8ADB067158557A867F1D7E09C32AA3244C2DB2C0FE609B8F9A7B0DC8E7D22A103AE2381EA10B52BC17EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojamSMdo1tbG/j3PzL4G+S/g== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F25884581B222C4EA6E9DB8F56704ABB56AC4A0F3A4BFDD17D83B6909B31AC26E052EA8D645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 7/7] test: set LD_PRELOAD only when necessary X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------dQMu8Ld3RennQGHSUknUj9ne Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 24.09.2024 18:23, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Fixed your comment and force-pushed the branch. > > On 24.09.24, Sergey Bronnikov wrote: >> Hi, Sergey, >> >> On 24.09.2024 13:29, Sergey Kaplun wrote: >>> This patch sets LD_PRELOAD for ASan build for the required tests instead >>> of all tests. >>> >>> Follows up tarantool/tarantool#9898 >> probably follows up these commits as well: >> >> >> commit 9f1137bcc890c28c5de24497624553574d371007    "cmake: replace prove >> with CTest" >> >> commit abe1e0aca3ad01f89f9d184c2a82949314814d04     "ci: execute LuaJIT >> tests with GCC 10 and ASAN" > I've opted the previous commit (where the corresponding FIXME is > introduced). The new commit message is: > > | test: set LD_PRELOAD only when necessary > | > | As a follow-up for 888adcfb72e361b150a9038407eb1dc9bd3392bd ("test: fix > | lj-802-panic-at-mcode-protfail GCC+ASan"), this patch sets LD_PRELOAD > | for ASan build for the required tests instead of all tests. > | > | Follows up tarantool/tarantool#9898 Thanks! LGTM > > >> LGTM >> >>> --- > > --------------dQMu8Ld3RennQGHSUknUj9ne Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 24.09.2024 18:23, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Fixed your comment and force-pushed the branch.

On 24.09.24, Sergey Bronnikov wrote:

Hi, Sergey,

On 24.09.2024 13:29, Sergey Kaplun wrote:

This patch sets LD_PRELOAD for ASan build for the required tests instead
of all tests.

Follows up tarantool/tarantool#9898

probably follows up these commits as well:


commit 9f1137bcc890c28c5de24497624553574d371007    "cmake: replace prove 
with CTest"

commit abe1e0aca3ad01f89f9d184c2a82949314814d04     "ci: execute LuaJIT 
tests with GCC 10 and ASAN"

I've opted the previous commit (where the corresponding FIXME is
introduced). The new commit message is:

| test: set LD_PRELOAD only when necessary
|
| As a follow-up for 888adcfb72e361b150a9038407eb1dc9bd3392bd ("test: fix
| lj-802-panic-at-mcode-protfail GCC+ASan"), this patch sets LD_PRELOAD
| for ASan build for the required tests instead of all tests.
|
| Follows up tarantool/tarantool#9898
Thanks! LGTM



LGTM


---

<snipped>
--------------dQMu8Ld3RennQGHSUknUj9ne--