From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 74CA4198062D; Mon, 16 Mar 2026 11:22:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 74CA4198062D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1773649374; bh=Ju+P270ff7I1Z6I4kGiozRcPoZk+dJ4mXoijZ94wlbM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=g+MCq63IQZpmP7ShrMsF0v4EDpSXO6I/+xYjVNGZhBzH7scuyPhE/f9+gAidhQ4IL cwD7VPizxqoRALKp82OtUap72LtbboW0jjrjvCVtdfp5e63UwVSEhvpmwuEM9xqLIg 7BtZu6uTvyx6/ltLGjgvnc11n3mG2A66HLtcxuJQ= Received: from send172.i.mail.ru (send172.i.mail.ru [95.163.59.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 28A47198062D for ; Mon, 16 Mar 2026 11:22:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 28A47198062D Received: by exim-smtp-64cdfc6c8d-nl8dl with esmtpa (envelope-from ) id 1w23Dv-00000000TGO-4AmX; Mon, 16 Mar 2026 11:22:52 +0300 Content-Type: multipart/alternative; boundary="------------3xginuiAsy6r3b8c9b9mYRqx" Message-ID: Date: Mon, 16 Mar 2026 11:22:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun , tarantool-patches@dev.tarantool.org References: <334e8dd174e6f4c9a03b3a5827c36d5353a85238.1773330679.git.skaplun@tarantool.org> <4454d7e1-43a6-4151-b39f-26fec9a7f04d@tarantool.org> <256a4bfa-edea-4971-b5c3-3b94a102c6d9@tarantool.org> Content-Language: en-US In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91ABAE9865AC7DC88E3B882EBCA423B4D3BB7B2ACD2117197182A05F538085040D701A8F17EDA188B3DE06ABAFEAF670551DEDE9CC30F31C4A2450BF1717AD9E0BD6D9258D404D2D2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B8498AC83B273C12EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566BCD8AD057D84402C4BB59E5304269F6064F615AED69C0675C35A32DE46BE5DD1389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C04CF195F1528592878941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6E232F00D8D26902CA471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C0B02670E5FEECA50C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5ECCBD9370B7F5CEE5002B1117B3ED69684908CE18F06820F886DC9BC01168B20823CB91A9FED034534781492E4B8EEAD3CCD70CEBBF18A22BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65973A35849E36A5F6E8E311FA79BEDAF34889F76149C955C02C29F859EC7DB632D983B3AE1D1F1A008B8341EE9D5BE9A0A2163905DFC10C294FF7FEB8959EDD9AAF03FA30E74ADB4038CD93680B12512CF4C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdbVVJCphTR/yOaL14z2Bt4= X-DA7885C5: 4298606B0BAFF53AF255D290C0D534F9F5F361EE30F40C69691B2EA7085691493AD1ED109F60FA9E5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE2A228A2A571A86641E1944C31CE9FBAC312774A78C94F2774EF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Prevent recording of loops with -0 step or NaN values. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------3xginuiAsy6r3b8c9b9mYRqx Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for update. LGTM then. Sergey On 3/16/26 10:37, Sergey Kaplun wrote: > Sergey, > > Updated the comment as we discussed offline. > Branch is force-pushed. > > On 13.03.26, Sergey Kaplun via Tarantool-patches wrote: >> > Made the comment more verbose: Thanks, I suppose it is more clear now for readers. > > =================================================================== > diff --git a/test/tarantool-tests/lj-1432-minus-zero-step.test.lua b/test/tarantool-tests/lj-1432-minus-zero-step.test.lua > index 112153dc..e3b97dde 100644 > --- a/test/tarantool-tests/lj-1432-minus-zero-step.test.lua > +++ b/test/tarantool-tests/lj-1432-minus-zero-step.test.lua > @@ -42,7 +42,7 @@ end > > local function test_trace_recorded(test_payload) > jit.flush() > - -- Reset hotcounters. > + -- XXX: Reset hotcounters to avoid false-positive collisions. > jit.opt.start('hotloop=1', 'hotexit=1') > test_payload() > return traceinfo(1) > diff --git a/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua b/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua > index b9e5ad92..f7566d6a 100644 > --- a/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua > +++ b/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua > @@ -62,7 +62,7 @@ end > > local function test_trace_recorded(test_payload) > jit.flush() > - -- Reset hotcounters. > + -- XXX: Reset hotcounters to avoid false-positive collisions. > jit.opt.start('hotloop=1', 'hotexit=1') > test_payload() > return traceinfo(1) > =================================================================== > >>> >> -- >> Best regards, >> Sergey Kaplun --------------3xginuiAsy6r3b8c9b9mYRqx Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for update. LGTM then.

Sergey

On 3/16/26 10:37, Sergey Kaplun wrote:
Sergey,

Updated the comment as we discussed offline.
Branch is force-pushed.

On 13.03.26, Sergey Kaplun via Tarantool-patches wrote:

<snipped> 
Made the comment more verbose:
Thanks, I suppose it is more clear now for readers. 

===================================================================
diff --git a/test/tarantool-tests/lj-1432-minus-zero-step.test.lua b/test/tarantool-tests/lj-1432-minus-zero-step.test.lua
index 112153dc..e3b97dde 100644
--- a/test/tarantool-tests/lj-1432-minus-zero-step.test.lua
+++ b/test/tarantool-tests/lj-1432-minus-zero-step.test.lua
@@ -42,7 +42,7 @@ end
 
 local function test_trace_recorded(test_payload)
   jit.flush()
-  -- Reset hotcounters.
+  -- XXX: Reset hotcounters to avoid false-positive collisions.
   jit.opt.start('hotloop=1', 'hotexit=1')
   test_payload()
   return traceinfo(1)
diff --git a/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua b/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua
index b9e5ad92..f7566d6a 100644
--- a/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua
+++ b/test/tarantool-tests/lj-1433-nan-for-loop-control-var.test.lua
@@ -62,7 +62,7 @@ end
 
 local function test_trace_recorded(test_payload)
   jit.flush()
-  -- Reset hotcounters.
+  -- XXX: Reset hotcounters to avoid false-positive collisions.
   jit.opt.start('hotloop=1', 'hotexit=1')
   test_payload()
   return traceinfo(1)
===================================================================



        

          

          

            

          

          
<snipped>


        

        
-- 
Best regards,
Sergey Kaplun


      

      

    

  
  


--------------3xginuiAsy6r3b8c9b9mYRqx--