From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A763C469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 10 Jun 2020 01:28:20 +0300 (MSK)
References: <cover.1590671266.git.imeevma@gmail.com>
 <40caa8fdc66d3d20aca72677e10014e749172f92.1590671266.git.imeevma@gmail.com>
 <1fdaea95-07d2-72ac-82bc-24e0c8fa4ed0@tarantool.org>
 <ba928c0c-1781-21d5-d182-30d069f5c2ee@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <c4733a22-9ba5-fb00-9b02-28e11c80f6de@tarantool.org>
Date: Wed, 10 Jun 2020 00:28:17 +0200
MIME-Version: 1.0
In-Reply-To: <ba928c0c-1781-21d5-d182-30d069f5c2ee@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH 4/6] sql: remove mem_apply_type()
	from OP_MustBeInt
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Mergen Imeev <imeevma@tarantool.org>, tsafin@tarantool.org, tarantool-patches@dev.tarantool.org

Thanks for the patch!

See 2 comments below.

> diff --git a/test/sql-tap/join.test.lua b/test/sql-tap/join.test.lua
> index 840b780a3..51e0ecb79 100755
> --- a/test/sql-tap/join.test.lua
> +++ b/test/sql-tap/join.test.lua
> @@ -1034,7 +1034,6 @@ test:do_execsql_test(
>          SELECT * FROM t1 NATURAL JOIN t2
>      ]], {
>          -- <join-11.9>
> -        "one", "1", "two", "2"
>          -- </join-11.9>
>      })

1. Why does "join-11.10" still work? I see it started failing
in the next commits, but why not here?

> diff --git a/test/sql-tap/tkt-9a8b09f8e6.test.lua b/test/sql-tap/tkt-9a8b09f8e6.test.lua
> index cb5348ab4..854ed774f 100755
> --- a/test/sql-tap/tkt-9a8b09f8e6.test.lua
> +++ b/test/sql-tap/tkt-9a8b09f8e6.test.lua
> @@ -189,7 +189,6 @@ test:do_execsql_test(
>          SELECT x FROM t2 WHERE x IN ('1');
>      ]], {
>          -- <3.3>
> -        1
>          -- </3.3>
>      })
> 
> @@ -199,7 +198,6 @@ test:do_execsql_test(
>          SELECT x FROM t2 WHERE x IN ('1');
>      ]], {
>          -- <3.4>
> -        1
>          -- </3.4>
>      })
> 
> @@ -229,7 +227,6 @@ test:do_execsql_test(
>          SELECT x FROM t2 WHERE '1' IN (x);
>      ]], {
>          -- <3.7>
> -        1
>          -- </3.7>
>      })
> 
> @@ -239,7 +236,6 @@ test:do_execsql_test(
>          SELECT x FROM t2 WHERE '1' IN (x);
>      ]], {
>          -- <3.8>
> -        1
>          -- </3.8>

2. 3.7 and 3.8 are absolutely the same. Maybe better to drop
one of them. The same about 3.4 <-> 3.3.