From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A6B826EC60; Tue, 30 Mar 2021 02:09:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A6B826EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617059394; bh=PjvtuWNDmE3F1OC+j9yoTtIX5MCO1NCacFif4zfhJ18=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=yLV5uiMaufMNfJc6VTc3XjzsIuwCHqCXxZ0coFRop3d8D3b99TTVNZqZFaZ6w4/w9 cdxDFpCvwUkRYBz9e9TbGN5fuA7dV3zEgYYGv5CcqDhDpf3cLsF3q2IoXUP5Pe/CiN SLUS7GfZSZqXALlfmB5U7/MjVu7+/pfGzg7wcKTg= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D29306EC60 for ; Tue, 30 Mar 2021 02:06:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D29306EC60 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lR0xZ-0007oy-3t; Tue, 30 Mar 2021 02:06:13 +0300 To: imeevma@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <51c8df44fb6a093d97d97a789b677e45596cc930.1616491731.git.imeevma@gmail.com> Message-ID: Date: Tue, 30 Mar 2021 01:06:12 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <51c8df44fb6a093d97d97a789b677e45596cc930.1616491731.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947A0146560F8BA709E798FFD99D1B1662182A05F5380850404E2EC5187F475489BAEB216E73D12FC4856BB711C36588C2ACAF8FED8811787D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE746D93DAA4671895CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374FBED2B83F5E00CA8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFA961EBEF0F2AA5852385A59123F06BFDA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE74A95F4E53E8DCE969FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C31A3F3A3731258CC5117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735F43AACC0BCEB2632C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5D34FE96B4BFCCDF17A06A8329C9D54F0FDFB288520394761D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3403182E70AE6895E0E269C7D56884E6C9DEAFF226E170BC8A3758675B175E732DCC80E64A68AC61831D7E09C32AA3244C120EA6100CC154F3E9F85D01D226C791BBA718C7E6A9E042FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rRtT9xuTmOkbw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822C5D1C6F9CCB8A81EB9E6F5D553932F253841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 36/53] sql: introduce mem_set_pointer() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! I think mem_set_ptr() name was better. Was shorter and still easy to understand. > diff --git a/src/box/sql/mem.c b/src/box/sql/mem.c > index fd2710478..3701741ef 100644 > --- a/src/box/sql/mem.c > +++ b/src/box/sql/mem.c > @@ -595,6 +595,15 @@ mem_set_undefined(struct Mem *mem) > mem->field_type = field_type_MAX; > } > > +void > +mem_set_pointer(struct Mem *mem, void *ptr) > +{ > + mem_clear(mem); > + mem->flags = MEM_Ptr; > + mem->u.p = ptr; > + mem->field_type = field_type_MAX; mem_clear() already sets the type.