From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 57E95469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 19 May 2020 00:57:08 +0300 (MSK)
References: <cover.1589799677.git.alexander.turenko@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <c44cbb04-5e3e-f05e-4212-13cea211c125@tarantool.org>
Date: Mon, 18 May 2020 23:57:06 +0200
MIME-Version: 1.0
In-Reply-To: <cover.1589799677.git.alexander.turenko@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 0/2] popen fixes
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>, "Alexander V . Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the patchset!

It works on my machine, LGTM.

On 18/05/2020 13:42, Alexander Turenko wrote:
> The patchset fixes two problems in the popen implementation and the
> test, which fails testing on Mac OS from time to time.
> 
> https://github.com/tarantool/tarantool/issues/4995
> https://github.com/tarantool/tarantool/issues/4938
> Totktonada/popen-fixes
> 
> Alexander Turenko (2):
>   popen: fix access to freed memory after :close()
>   test: popen: fix popen test 'hang' under test-run
> 
>  src/lib/core/popen.c        |  5 +++++
>  src/lua/popen.c             | 11 +++++++++--
>  test/app-tap/popen.test.lua | 24 +++++++++++++++++++++++-
>  3 files changed, 37 insertions(+), 3 deletions(-)
>