From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B77D1DB66FF; Tue, 17 Dec 2024 14:08:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B77D1DB66FF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1734433721; bh=obBdowmn5b2nBxAibJBgEhggmQvpE4XEbbX17WImYBw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=n3DmZV22MJ8H8A6Pcbaslp74n0LoC3Y134lPeiLBqPvS37irR7TgMLwYt2j9VQ0qg jS4CokF7W6L2W3VoC0OrMlMtmHXrJVFeGE1b84FxUYTs/S0FRR0bMN4bxPSH/dVYi1 dM6gQmxIuui3hGFypiB4nSgKzeE1r9tbteyJAYS8= Received: from send242.i.mail.ru (send242.i.mail.ru [95.163.59.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6F1544363FD for ; Tue, 17 Dec 2024 14:08:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6F1544363FD Received: by exim-smtp-84dbd655b7-wxw56 with esmtpa (envelope-from ) id 1tNVRP-000000002dw-1h8i; Tue, 17 Dec 2024 14:08:39 +0300 Content-Type: multipart/alternative; boundary="------------A7MfmmNbL34BWVQVCfwJXZPC" Message-ID: Date: Tue, 17 Dec 2024 14:08:38 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun Cc: Maksim Tiushev , tarantool-patches@dev.tarantool.org References: Content-Language: en-US In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD977EAE61095F37AC5339275A2857064A2E5509CB994280930182A05F538085040BCCAB04B2E6D9B223DE06ABAFEAF67051252B68889E7DC48832CCABE3DAF225C58574C2FEBD6103D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77E216A0E97507353EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376AFB9B40001E44068638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D89BBDEDAB5B908870524951229918BB118219392D15923AB7CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8062BEEFFB5F8EA3EF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C86A7C529F68B8E5C6136E347CC761E074AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3CB7BFC332BD7EEB0BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166176DF2183F8FC7C04E672349037D5FA5725E5C173C3A84C31C94431981024FA535872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5BC77AD76029976775002B1117B3ED696F768124D56BDF350B2920F75BA9A967F823CB91A9FED034534781492E4B8EEADEEA082C9A12FE455BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34A503FBFE8BE8FC49351FCD762B7D2DB4627D57FB2C228F41433C6F46C7004C57DE4834551ABE9EDA1D7E09C32AA3244CC6B28D79A8CA4CD977DD89D51EBB7742567E4817541711A6EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrmbv0RPnqfT2BQ+AlNv1Uw== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F258845862585177F60E0328E9E07FF329DA7D47635DBA31BF0FAC8AEABC5CCBA5110642645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 luajit 1/3] Ensure full init of IR_NOP instructions. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------A7MfmmNbL34BWVQVCfwJXZPC Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello, LGTM On 16.12.2024 14:24, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > > On 13.12.24, Sergey Bronnikov wrote: >> Hello, Sergey, >> >> thanks for the patch! LGTM with a minor comment. >> >> On 11.12.2024 16:21, Sergey Kaplun wrote: >>> From: Mike Pall >>> >>> (cherry picked from commit de6b1a11dd1a3349179084578c5d533be1c30234) >>> >>> Before this patch, Valgrind produces tons of warnings during the VMevent >>> calls since the `IR_NOP` instruction isn't fully initialized. Hence, any >>> parsing operations for it in handlers during `jit.dump()` leads to the >>> "uninitialised value" error. This patch fixes the issue by the proper >>> init of such IRs. >> Please add to a comment that with these tests the problem could >> >>  be reproduced: >> >> test/tarantool-tests/lj-1128-table-new-opt-tnew.test.lua >> >> test/tarantool-tests/fix-jit-dump-ir-conv.test.lua >> >> test/tarantool-tests/unit-jit-parse.test.lua > Updated. The new commit message is the following: > > | Ensure full init of IR_NOP instructions. > | > | (cherry picked from commit de6b1a11dd1a3349179084578c5d533be1c30234) > | > | Before this patch, Valgrind produces tons of warnings during the VMevent > | calls since the `IR_NOP` instruction isn't fully initialized. Hence, any > | parsing operations for it in handlers during `jit.dump()` leads to the > | "uninitialised value" error. > | > | This can be reproduced with the following tests from the > | tarantool-tests suite: > | * fix-jit-dump-ir-conv.test.lua > | * lj-1128-table-new-opt-tnew.test.lua > | * lj-981-folding-0.test.lua > | * unit-jit-parse.test.lua > | > | This patch fixes the issue by the proper init of such IRs. > | > | Sergey Kaplun: > | * added the description for the problem > | > | Needed for tarantool/tarantool#3705 > | Part of tarantool/tarantool#10709 > >>> Sergey Kaplun: >>> * added the description for the problem >>> >>> Needed for tarantool/tarantool#3705 >>> Part of tarantool/tarantool#10709 >>> --- > > --------------A7MfmmNbL34BWVQVCfwJXZPC Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hello,


LGTM

On 16.12.2024 14:24, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!

On 13.12.24, Sergey Bronnikov wrote:

Hello, Sergey,

thanks for the patch! LGTM with a minor comment.

On 11.12.2024 16:21, Sergey Kaplun wrote:

From: Mike Pall <mike>

(cherry picked from commit de6b1a11dd1a3349179084578c5d533be1c30234)

Before this patch, Valgrind produces tons of warnings during the VMevent
calls since the `IR_NOP` instruction isn't fully initialized. Hence, any
parsing operations for it in handlers during `jit.dump()` leads to the
"uninitialised value" error. This patch fixes the issue by the proper
init of such IRs.

Please add to a comment that with these tests the problem could

  be reproduced:

test/tarantool-tests/lj-1128-table-new-opt-tnew.test.lua

test/tarantool-tests/fix-jit-dump-ir-conv.test.lua

test/tarantool-tests/unit-jit-parse.test.lua

Updated. The new commit message is the following:

| Ensure full init of IR_NOP instructions.
|
| (cherry picked from commit de6b1a11dd1a3349179084578c5d533be1c30234)
|
| Before this patch, Valgrind produces tons of warnings during the VMevent
| calls since the `IR_NOP` instruction isn't fully initialized. Hence, any
| parsing operations for it in handlers during `jit.dump()` leads to the
| "uninitialised value" error.
|
| This can be reproduced with the following tests from the
| tarantool-tests suite:
| * fix-jit-dump-ir-conv.test.lua
| * lj-1128-table-new-opt-tnew.test.lua
| * lj-981-folding-0.test.lua
| * unit-jit-parse.test.lua
|
| This patch fixes the issue by the proper init of such IRs.
|
| Sergey Kaplun:
| * added the description for the problem
|
| Needed for tarantool/tarantool#3705
| Part of tarantool/tarantool#10709



        

          
Sergey Kaplun:
* added the description for the problem

Needed for tarantool/tarantool#3705
Part of tarantool/tarantool#10709
---


        

      

      
<snipped>



    

  
  


--------------A7MfmmNbL34BWVQVCfwJXZPC--